Fix agtype_build_map to allow more than 50 pairs (#1901) #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed agtype_build_map to allow objects to be created with more than 50 pairs. This is a PostgreSQL limitation on the number of function arguments. To achieve this, the agtype_add, aka concat operator, was used to concat objects together when the limit was reached for the number of arguments. Added regression tests.
rafsun42
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed agtype_build_map to allow objects to be created with more than 50 pairs. This is a PostgreSQL limitation on the number of function arguments.
To achieve this, the agtype_add, aka concat operator, was used to concat objects together when the limit was reached for the number of arguments.
Added regression tests.