-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function is_valid_label_name (#1911) #1912
Merged
rafsun42
merged 1 commit into
apache:master
from
jrgemignani:add_label_name_validation_function
Jun 14, 2024
Merged
Add function is_valid_label_name (#1911) #1912
rafsun42
merged 1 commit into
apache:master
from
jrgemignani:add_label_name_validation_function
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the function is_valid_label_name (apache#1911) per user request. This function will return a boolean value for any agtype string passed, depending on whether it is a valid name for a label. For all other types, not an agtype string, it will error out. Depending on user requirements, this could be changed in the future. Added regression tests.
github-actions
bot
added
master
override-stale
To keep issues/PRs untouched from stale action
labels
Jun 13, 2024
MuhammadTahaNaveed
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me !!
rafsun42
approved these changes
Jun 14, 2024
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Jun 14, 2024
Added the function is_valid_label_name (apache#1911) per user request. This function will return a boolean value for any agtype string passed, depending on whether it is a valid name for a label. For all other types, not an agtype string, it will error out. Depending on user requirements, this could be changed in the future. Added regression tests.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Jun 14, 2024
Added the function is_valid_label_name (apache#1911) per user request. This function will return a boolean value for any agtype string passed, depending on whether it is a valid name for a label. For all other types, not an agtype string, it will error out. Depending on user requirements, this could be changed in the future. Added regression tests.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Jun 14, 2024
Added the function is_valid_label_name (apache#1911) per user request. This function will return a boolean value for any agtype string passed, depending on whether it is a valid name for a label. For all other types, not an agtype string, it will error out. Depending on user requirements, this could be changed in the future. Added regression tests.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Jun 15, 2024
Added the function is_valid_label_name (apache#1911) per user request. This function will return a boolean value for any agtype string passed, depending on whether it is a valid name for a label. For all other types, not an agtype string, it will error out. Depending on user requirements, this could be changed in the future. Added regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the function is_valid_label_name (#1911) per user request.
This function will return a boolean value for any agtype string passed, depending on whether it is a valid name for a label. For all other types, not an agtype string, it will error out. Depending on user requirements, this could be changed in the future.
Added regression tests.