Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function is_valid_label_name (#1911) #1912

Merged

Conversation

jrgemignani
Copy link
Contributor

Added the function is_valid_label_name (#1911) per user request.

This function will return a boolean value for any agtype string passed, depending on whether it is a valid name for a label. For all other types, not an agtype string, it will error out. Depending on user requirements, this could be changed in the future.

Added regression tests.

Added the function is_valid_label_name (apache#1911) per user request.

This function will return a boolean value for any agtype string
passed, depending on whether it is a valid name for a label. For
all other types, not an agtype string, it will error out. Depending
on user requirements, this could be changed in the future.

Added regression tests.
Copy link
Member

@MuhammadTahaNaveed MuhammadTahaNaveed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me !!

@rafsun42 rafsun42 merged commit ed810ef into apache:master Jun 14, 2024
7 checks passed
jrgemignani added a commit to jrgemignani/age that referenced this pull request Jun 14, 2024
Added the function is_valid_label_name (apache#1911) per user request.

This function will return a boolean value for any agtype string
passed, depending on whether it is a valid name for a label. For
all other types, not an agtype string, it will error out. Depending
on user requirements, this could be changed in the future.

Added regression tests.
jrgemignani added a commit to jrgemignani/age that referenced this pull request Jun 14, 2024
Added the function is_valid_label_name (apache#1911) per user request.

This function will return a boolean value for any agtype string
passed, depending on whether it is a valid name for a label. For
all other types, not an agtype string, it will error out. Depending
on user requirements, this could be changed in the future.

Added regression tests.
jrgemignani added a commit to jrgemignani/age that referenced this pull request Jun 14, 2024
Added the function is_valid_label_name (apache#1911) per user request.

This function will return a boolean value for any agtype string
passed, depending on whether it is a valid name for a label. For
all other types, not an agtype string, it will error out. Depending
on user requirements, this could be changed in the future.

Added regression tests.
jrgemignani added a commit to jrgemignani/age that referenced this pull request Jun 15, 2024
Added the function is_valid_label_name (apache#1911) per user request.

This function will return a boolean value for any agtype string
passed, depending on whether it is a valid name for a label. For
all other types, not an agtype string, it will error out. Depending
on user requirements, this could be changed in the future.

Added regression tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master override-stale To keep issues/PRs untouched from stale action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants