Add EmitWarningsOnPlaceholders("age") (#1997) #1998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyaaa
force-pushed
the
add-emit-warnings-on-placeholders-pg13
branch
from
60a96c2 to
50532c7
Compare
shinyaaa
changed the title
shinyaaa
force-pushed
the
add-emit-warnings-on-placeholders-pg13
branch
from
50532c7 to
6f0ad97
Compare
|
@shinyaaa There appears to be an issue with the build regression for this one :( Please look into it when you have an opportunity - |
|
Hi @shinyaaa the regression tests are failing for PG13 and 14. |
shinyaaa
force-pushed
the
add-emit-warnings-on-placeholders-pg13
branch
from
6f0ad97 to
cd18aa4
Compare
|
@jrgemignani @rafsun42 Until v14, it seems to warn only when PostgreSQL starts. |
Added EmitWarningsOnPlaceholders("age") to warn when an undefined GUC parameter is set for a placeholder named "age".
Warnings are issued when PostgreSQL starts.
When PostgreSQL starts
```
2024-08-01 18:32:31.220 JST [2039799] WARNING: invalid configuration parameter name "age.invalid_parameter", removing it
```
shinyaaa
force-pushed
the
add-emit-warnings-on-placeholders-pg13
branch
from
cd18aa4 to
d7689d1
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove "Abondoned" label or comment or this will be closed in 14 days. |
|
This PR was closed because it has been stalled for further 14 days with no activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EmitWarningsOnPlaceholders("age") to warn when an undefined GUC parameter is set for a placeholder named "age".
Warnings are issued when PostgreSQL starts and when SET statements are executed.
When PostgreSQL starts
When SET statement is executed
Regression tests were added.