-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker Instruction added for accessing Postgres shell #422
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
``` | ||
<h5> Create AGE docker container </h5> | ||
<h5> Create age docker container for first time</h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can capitalize the age
word here as it holds significance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the container name is case sensitive... Container won't run otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the title, affecting the case of the alphabet won't make any difference in the running of the code. The case-sensitive line is 193 specifying the image to pull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
README.md
Outdated
@@ -195,7 +193,23 @@ docker run \ | |||
apache/age | |||
``` | |||
|
|||
<h5> Or Run docker container if you previously worked with age container </h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, capitalize the age
keyword here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the container name is case sensitive... Container won't run otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only a task description so you can capitalize the alphabet here. The main script is line 199 which should be case sensitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Instruction Added
Removed