Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added video links #634

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Added video links #634

merged 2 commits into from
Feb 7, 2023

Conversation

waleedahmed0001
Copy link
Contributor

@waleedahmed0001 waleedahmed0001 commented Jan 28, 2023

Added different video tutorials in it which will help in the installation of Apache Age on Windows and macOS.

@jrgemignani jrgemignani requested a review from eyab January 31, 2023 20:06
@jbiz805
Copy link
Contributor

jbiz805 commented Feb 1, 2023

Hi waleedahmed0001, thanks for taking the time in contributing to the readme file!
Any new additions in the readme are welcome, as long as it is kept within the format.
I've got some comments to share regarding the addition you made so please consider refining it and request again.

unnamed

1) Icon

  • Include an icon that represents Video Links (refer to other titles)
    2) Specify which OS
  • Specify which installation it's for. The link provided is Windows (made by one of the interns)
  • also add MacOS edition
  • name the link differently. For Example, "Install on Windows" (enter+new bullet point) "Install on MacOS"
    3) Outdated
  • This link is a webinar on AGE during the incubating stage. The details are outdated. Remove.
    4) For Internal use only
  • This video is only shared with AGE internal personnel. It should not be open to public.

Final comment:
Though having a video to explain AGE is a splendid idea, this is a readme.
Take into consideration if visitors will watch long webinar videos.

Thank you!

@waleedahmed0001
Copy link
Contributor Author

Hi waleedahmed0001, thanks for taking the time in contributing to the readme file! Any new additions in the readme are welcome, as long as it is kept within the format. I've got some comments to share regarding the addition you made so please consider refining it and request again.

unnamed

1) Icon

  • Include an icon that represents Video Links (refer to other titles)
    2) Specify which OS
  • Specify which installation it's for. The link provided is Windows (made by one of the interns)
  • also add MacOS edition
  • name the link differently. For Example, "Install on Windows" (enter+new bullet point) "Install on MacOS"
    3) Outdated
  • This link is a webinar on AGE during the incubating stage. The details are outdated. Remove.
    4) For Internal use only
  • This video is only shared with AGE internal personnel. It should not be open to public.

Final comment: Though having a video to explain AGE is a splendid idea, this is a readme. Take into consideration if visitors will watch long webinar videos.

Thank you!

I will do these changes and then commit

@jbiz805
Copy link
Contributor

jbiz805 commented Feb 6, 2023

Check your spelling!
Once the spelling is fixed i think it's good to go imo, @jrgemignani

@jrgemignani
Copy link
Contributor

@waleedahmed0001 Please -

  • Squash your Github comments to what is necessary.
  • Use the present tense for the commit description.

After that, it looks good. @jbiz805?

@jbiz805
Copy link
Contributor

jbiz805 commented Feb 6, 2023

looks good to me now @jrgemignani

@jrgemignani
Copy link
Contributor

@waleedahmed0001 Please -

  • Squash your Github comments to what is necessary.
  • Use the present tense for the commit description.

After that, it looks good. @jbiz805?

Just waiting on this.

Added different video tutorials in it which will help in installation of Apache Age on Windows and macOS.
@waleedahmed0001
Copy link
Contributor Author

@waleedahmed0001 Please -

  • Squash your Github comments to what is necessary.
  • Use the present tense for the commit description.

After that, it looks good. @jbiz805?

Just waiting on this.

I am done with those changes. You can review it.

@jrgemignani jrgemignani merged commit 9622656 into apache:master Feb 7, 2023
jrgemignani pushed a commit that referenced this pull request Feb 14, 2023
Added different video tutorials in it which will help in installation of Apache Age on Windows and MacOS.
jrgemignani pushed a commit that referenced this pull request Feb 15, 2023
Added different video tutorials in it which will help in installation of Apache Age on Windows and MacOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants