Fix example_dags and system tests "source" links in documentation #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
potiuk
force-pushed
the
fix-historically-wrong-source-links
branch
from
56eeba3 to
40b0877
Compare
ashb
requested changes
Jun 13, 2022
docs-archive/apache-airflow-providers-airbyte/2.1.1/operators/airbyte.html
Outdated
Show resolved
Hide resolved
potiuk
force-pushed
the
fix-historically-wrong-source-links
branch
from
40b0877 to
5b02fdc
Compare
|
Hey @ashb - re-rerun the scripts on base changes and airbyte is gone. I think it could be a remnant of the initial tests I've done. I'v optimized the scripts as well (less throttling possibility). |
ashb
reviewed
Jun 14, 2022
docs-archive/apache-airflow-providers-apache-beam/4.0.0/operators.html
Outdated
Show resolved
Hide resolved
potiuk
force-pushed
the
fix-historically-wrong-source-links
branch
from
5b02fdc to
e1cefc7
Compare
|
Fix applied @ashb |
|
Looks like the list of affected files is "about right" this time https://gist.github.com/potiuk/fca7dca641044a200a81b3ab236fba52 |
|
BTW . As suspected, seems that the root cause was the sphinx upgrade apache/airflow#20170 - the example links were missing since Airflow 2.2.4 where it was cherry-picked to and all providers affected were released after 9 Dec when it got merged. |
|
Hey @ashb - shall we merge it ? Seems all issues are fixed. |
|
(and users get 404s now ) |
ashb
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of running the scripts from
apache/airflow#24389
Fixes: apache/airflow#23632