Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openlineage: readd few removed Task properties in AirflowRunFacet #40371 #46016

Closed
1 of 2 tasks
Mohammed-Karim226 opened this issue Jan 24, 2025 · 1 comment
Closed
1 of 2 tasks
Labels
AI Spam area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet provider:openlineage AIP-53

Comments

@Mohammed-Karim226
Copy link

Apache Airflow version

main (development)

If "Other Airflow 2 version" selected, which one?

No response

What happened?

In PR #38264, a few Task properties in the AirflowRunFacet were accidentally removed. This caused missing serialization of these properties, which are necessary for proper functionality in the OpenLineage provider.

What you think should happen instead?

The removed Task properties should be serialized in the AirflowRunFacet as they were before PR #38264. This ensures compatibility and correct functionality for OpenLineage integration.

How to reproduce

Use an Airflow deployment with OpenLineage provider enabled.

Check the serialized output of AirflowRunFacet for Task properties.

Observe that certain properties are missing after PR #38264.

Operating System

N/A (This is a code-level issue, not OS-specific.)

Versions of Apache Airflow Providers

providers-ydb/1.0.0rc1

Deployment

Official Apache Airflow Helm Chart

Deployment details

N/A (This is a code-level issue, not deployment-specific.)

Anything else?

Frequency

This issue occurs consistently for any Task using the affected AirflowRunFacet properties.

Fix

The issue was resolved in PR #40371, which reintroduced the missing properties.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Mohammed-Karim226 Mohammed-Karim226 added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jan 24, 2025
@Mohammed-Karim226 Mohammed-Karim226 changed the title Missing Task Properties in AirflowRunFacet After PR #38264 openlineage: readd few removed Task properties in AirflowRunFacet #40371 Jan 24, 2025
@dosubot dosubot bot added the provider:openlineage AIP-53 label Jan 24, 2025
@eladkal
Copy link
Contributor

eladkal commented Jan 25, 2025

Ai bot

@eladkal eladkal closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Spam area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet provider:openlineage AIP-53
Projects
None yet
Development

No branches or pull requests

2 participants