[OpenLineage] Remove redundant operator information from facets #38264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpermuda
force-pushed
the
ol/remove-redundant-task-information-from-facets
branch
from
a7ac157 to
8c26dd6
Compare
kacpermuda
force-pushed
the
ol/remove-redundant-task-information-from-facets
branch
2 times, most recently
from
4843355 to
e8124d8
Compare
JDarDagran
approved these changes
Mar 18, 2024
kacpermuda
force-pushed
the
ol/remove-redundant-task-information-from-facets
branch
4 times, most recently
from
3b09779 to
ef156e3
Compare
kacpermuda
force-pushed
the
ol/remove-redundant-task-information-from-facets
branch
from
ef156e3 to
1bedc07
Compare
Signed-off-by: Kacper Muda <[email protected]>
kacpermuda
force-pushed
the
ol/remove-redundant-task-information-from-facets
branch
from
1bedc07 to
8f0708d
Compare
mobuchowski
approved these changes
Apr 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We encountered a case where a customer received an overly large OpenLineage START event, exceeding 2MB. This was traced back to an operator with unusually long arguments and attributes.
Solution
I propose refining the operator's attribute inclusion logic in facets. Instead of excluding known unimportant or large attributes, we should selectively include only those known to be important or compact. This approach ensures that custom operator attributes with substantial data do not inflate the event size.
I also deprecated two facets that contain duplicate information from AirflowRunFacet. We should probably remove them in the future.
Similar PR in
openlineage-airflow^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.