Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More meaningful name for @task.kubernetes pods by default #46464

Closed
2 tasks done
insomnes opened this issue Feb 5, 2025 · 7 comments · Fixed by #46535
Closed
2 tasks done

More meaningful name for @task.kubernetes pods by default #46464

insomnes opened this issue Feb 5, 2025 · 7 comments · Fixed by #46535
Assignees
Labels
area:providers kind:feature Feature Requests provider:cncf-kubernetes Kubernetes provider related issues

Comments

@insomnes
Copy link
Contributor

insomnes commented Feb 5, 2025

Description

Generate more meaningful default names for pods by @task.kubernetes with explicit randomness control

Use case/motivation

Reference PR with tests showing the desired changes:
#46462

Now pod created by decorator would have name f"k8s_airflow_pod_{uuid.uuid4().hex}" if name was not explicitly provided by the user.

I want more meaningful names by default (via python_callable name utilization) and to reuse already present randomness in name control option from KubernetesPodOperator: random_name_suffix.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@insomnes insomnes added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Feb 5, 2025
@insomnes insomnes changed the title Pod name based on decorated callable in @task.kubernetes tasks More meaningful name for @task.kubernetes pods by default Feb 5, 2025
@dosubot dosubot bot added area:providers provider:cncf-kubernetes Kubernetes provider related issues labels Feb 5, 2025
@RNHTTR RNHTTR removed the needs-triage label for new issues that we didn't triage yet label Feb 5, 2025
@RNHTTR
Copy link
Contributor

RNHTTR commented Feb 5, 2025

For future reference, there's no need to open an issue if you already have a PR submitted :)

@insomnes
Copy link
Contributor Author

insomnes commented Feb 5, 2025

Yeah, sorry for that, I thought that for features it's different from bug fixes. Thanks for clarifying this for me!

@insomnes
Copy link
Contributor Author

insomnes commented Feb 7, 2025

I think these changes also somewhat solve
#44779

@insomnes
Copy link
Contributor Author

insomnes commented Feb 8, 2025

Can someone with the rights please set reviewers (or even take a look) for the new PR?

It is redo of the PR already approved by Ryan, but I've messed it up during rebase for providers transition and closes it.

So after re-creation it fell in a loophole when CODEOWNERS file was broken due to mentioned transition, and no reviewers were set automatically.

#46535

@potiuk
Copy link
Member

potiuk commented Feb 8, 2025

Please do not "rush" things. You seem to be pretty impatient to get reviews. But this is open-source and people review things (and generally react) when they feel like they have some time or when they are interested in certain features or where someone is persistent (but also patient) enough to remind about their PR. BUT those are mostly volunteers here. 72 HRS for ANY reaction time is an absolute minimum you can expect. People here work in their free time often. They have holidays, weekens, sometimes families they tend to. Or simply might be busy at work and decide for a while not to spend their FREE time on the project.

And CODEOWNERS are not really well used so far - they were - in many cases not even used. I just - lterally an hour ago started a discussion about that on our devlist https://lists.apache.org/thread/xq7837nd2j99slb558ls7b6jqntq6y32 and if you would like to add your thinking on how things should be working there from a user perspective - you are absolutley free to joing the conversation (see community tab on our website to know how to join the devlist).

Generally speaking - you should be patient and wait for maintainers to pick an interest and if they don't, you should re-ping (again in -general - not individual people) after reasonable time - counted in several days, not hours. This is also described in our contribution guides - particularly https://github.com/apache/airflow/blob/main/contributing-docs/16_contribution_workflow.rst where you can learn more (and I suggest you generally read the whole contributor's guide - it's pretty good read).

Also - if I may suggest - open a few more PRs while you are waiting. One of the things here is that different areas are often tended to by different people and some of them might pick interested in different PRs faster of slower. By having several different things to work on you can account for the asynchronous - and apparently longer that maybe you are used to -feedback time. Having several things in parallel helps with that enormously.

@insomnes
Copy link
Contributor Author

insomnes commented Feb 8, 2025

My main concern was that the current approach for reviewing was not very clear to me, and missing the reviewers in PR was looking like it gonna stale as a lot of PRs here even with reviewers set. Thank you for pointing to the contribution workflow doc! I've missed it. I will take a proper read now to clear all things.

You are right that I am not used to "no reaction" for 24h+ and I should be more patient.
I didn't want to make any nuance and will try to implement your advice about multiple tasks to work on, thank you!
I am just really interested in the development of this awesome system.

I just - lterally an hour ago started a discussion about that on our devlist https://lists.apache.org/thread/xq7837nd2j99slb558ls7b6jqntq6y32

Yeah, I am already subscribed to the list and will try to add my 2 cents on the improvement of the process

@potiuk
Copy link
Member

potiuk commented Feb 8, 2025

My main concern was that the current approach for reviewing was not very clear to me, and missing the reviewers in PR was looking like it gonna stale as a lot of PRs here even with reviewers set. Thank you for pointing to the contribution workflow doc! I've missed it. I will take a proper read now to clear all things.

You are right that I am not used to "no reaction" for 24h+ and I should be more patient. I didn't want to make any nuance and will try to implement your advice about multiple tasks to work on, thank you! I am just really interested in the development of this awesome system.

I just - lterally an hour ago started a discussion about that on our devlist https://lists.apache.org/thread/xq7837nd2j99slb558ls7b6jqntq6y32

Yeah, I am already subscribed to the list and will try to add my 2 cents on the improvement of the process

Cool.. BTW. Sometimes even to "think" about the response will take time - and you also have to take into account that some people here handle multiple 100s PRs/Issues a week.

Patience and opening several streams of work to contribute is key ingredient of success in OSS contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:feature Feature Requests provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
3 participants