Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Endpoints - Read-only - XCOM #8134

Closed
mik-laj opened this issue Apr 4, 2020 · 4 comments · Fixed by #9170
Closed

API Endpoints - Read-only - XCOM #8134

mik-laj opened this issue Apr 4, 2020 · 4 comments · Fixed by #9170
Assignees
@randr97
Labels
area:API Airflow's REST/HTTP API good first issue kind:feature Feature Requests

Comments

@mik-laj
Copy link
Member

mik-laj commented Apr 4, 2020 •
edited
Loading

Description

Hello

We need to create several endpoints that perform basic read-only operations on XCOM . We need the following endpoints:

  • GET /dags/{dag_id}/taskInstances/{task_id}/{execution_date}/xcomValues
  • GET /dags/{dag_id}/taskInstances/{task_id}/{execution_date}/xcomValues/{key}

For now, we focus only on read-only operations, but the others will also be implemented as the next step.

Detailed information is available in the issue:
#8118

Use case / motivation
N/A

Related Issues
N/A
@mik-laj mik-laj added the kind:feature Feature Requests label Apr 4, 2020
@mik-laj mik-laj changed the title API Endpoint - CRUD - XCOM API Endpoints - CRUD - XCOM Apr 4, 2020
@mik-laj mik-laj added the area:API Airflow's REST/HTTP API label Apr 4, 2020
@mik-laj mik-laj mentioned this issue Apr 4, 2020
Closed
@mik-laj mik-laj mentioned this issue May 31, 2020
Closed
@randr97
Copy link
Contributor

randr97 commented Jun 2, 2020

Hi @mik-laj would be keen on working on this issue!

@mik-laj
Copy link
Member Author

mik-laj commented Jun 2, 2020

Thanks. For now, we're focusing on read-only endpoints. We need to build a scheme using Marshmallow compatible with OpenAPI. Soon I will write more information on Slack - #sig-api channel.

@mik-laj
Copy link
Member Author

mik-laj commented Jun 2, 2020

We are ready. You can start working from this file
https://github.com/apache/airflow/blob/master/airflow/api_connexion/endpoints/xcom_endpoint.py

You can be inspired by this change.
#9045

@mik-laj mik-laj changed the title API Endpoints - CRUD - XCOM API Endpoints - Read-only - XCOM Jun 2, 2020
@mik-laj mik-laj mentioned this issue Jun 2, 2020
Closed
@randr97
Copy link
Contributor

randr97 commented Jun 2, 2020

@mik-laj will be working on it thanks :)

@randr97 randr97 mentioned this issue Jun 7, 2020
Merged
6 tasks
randr97 added a commit to randr97/airflow that referenced this issue Jun 23, 2020
@randr97
Read only endpoint for XCom apache#8134
1dd3188
randr97 added a commit to randr97/airflow that referenced this issue Jun 23, 2020
@randr97
Read only endpoint for XCom apache#8134
e6ac7bb
mik-laj pushed a commit that referenced this issue Jun 25, 2020
@randr97 @ashb
Read only endpoint for XCom #8134 (#9170)
5744a47 
Co-authored-by: Ash Berlin-Taylor <[email protected]>
Co-authored-by: Kamil Breguła <[email protected]>
kaxil pushed a commit to kaxil/airflow that referenced this issue Jun 27, 2020
@randr97 @ashb @kaxil
Read only endpoint for XCom apache#8134 (apache#9170)
92d510e 
Co-authored-by: Ash Berlin-Taylor <[email protected]>
Co-authored-by: Kamil Breguła <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randr97 randr97

Labels
area:API Airflow's REST/HTTP API good first issue kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read only endpoint for XCom #8134 randr97/airflow
2 participants
@mik-laj @randr97