Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Salesforce connection type #8766

Closed
eladkal opened this issue May 7, 2020 · 16 comments · Fixed by #17162
Closed

Add custom Salesforce connection type #8766

eladkal opened this issue May 7, 2020 · 16 comments · Fixed by #17162

Comments

@eladkal
Copy link
Contributor

eladkal commented May 7, 2020

Description

Airflow has SalesforceHook but it doesn't have a defined connection.

In order to create a Connection one must expose it's secret token as text :

https://stackoverflow.com/questions/53510980/salesforce-connection-using-apache-airflow-ui

Also it's not very intuitive that the Conn Type should remain blank.

It would be easier and also user friendly if there will be salesforce connection in the UI which has a security_token field that is encrypted.

moved from https://issues.apache.org/jira/browse/AIRFLOW-6429

@eladkal eladkal added the kind:feature Feature Requests label May 7, 2020
@feluelle
Copy link
Member

Also it's not very intuitive that the Conn Type should remain blank.

That's true. At least there should be a howto docs guide on how to set up the connection properly.

@kaxil
Copy link
Member

kaxil commented Jul 15, 2020

That can be a good first-issue to add docs :) what to create that issue @feluelle ?

Also it's not very intuitive that the Conn Type should remain blank.

That's true. At least there should be a howto docs guide on how to set up the connection properly.

@feluelle
Copy link
Member

feluelle commented Jul 28, 2020

Sure! I am creating one.

@gtossou
Copy link

gtossou commented Oct 22, 2020

I would like to work on this issue

@eladkal
Copy link
Contributor Author

eladkal commented Nov 29, 2020

@gtossou are you still working on this?

@gtossou
Copy link

gtossou commented Nov 30, 2020

@gtossou are you still working on this?
@eladkal i'm still working on it. just figuring out the testing part before publishing a PR

@potiuk
Copy link
Member

potiuk commented Nov 30, 2020

@gtossou -> Just FYI, We just merged the first of the series of "auto-discovery" of Provider's capabilities, And we have defined a way how Providers can expose such connections to the Airflow Core (just in time for 2.0).

The most important (connection type discovery) is here 2037303

But few more are coming (see in progress items here: https://github.com/apache/airflow/projects/5)

I will soon also add a description on the "Discovering provider capabilities" (Connection Types, Connection Forms, Extra Links for now). Just wanted to you to be aware that this are is still going through some latest refinements before 2.0 release.

@eladkal
Copy link
Contributor Author

eladkal commented Feb 17, 2021

@gtossou are you still working on this issue?

@eladkal eladkal changed the title Add SalesForce connection type Add custom Salesforce connection type Feb 17, 2021
@cmarteepants
Copy link
Collaborator

cmarteepants commented Mar 10, 2021

@kaxil If nobody is working on this, would love to take this on!

@kaxil kaxil assigned cmarteepants and unassigned gtossou Mar 10, 2021
@kaxil
Copy link
Member

kaxil commented Mar 10, 2021

Assigned this to you @cmarteepants :) thanks

(Looks like @gtossou might be busy since they have responded yet)

@eladkal
Copy link
Contributor Author

eladkal commented Apr 13, 2021

@cmarteepants are you still working on this?
If you need some references you can check:
#14724
#15159

@cmarteepants
Copy link
Collaborator

cmarteepants commented Apr 14, 2021 via email

@eladkal
Copy link
Contributor Author

eladkal commented Jul 16, 2021

hi @cmarteepants rechecking you are still working on this issue?

@cmarteepants
Copy link
Collaborator

cmarteepants commented Jul 16, 2021

Hi @eladkal , thanks for checking. Please feel free to reassign. I should have let you know sooner, sorry if this causes any problems

@josh-fell
Copy link
Contributor

@eladkal I'm happy to take this on if still available.

@potiuk
Copy link
Member

potiuk commented Jul 21, 2021

assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants