-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingress to the helm chart #10064
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
cc @schnie if you have time |
# Ingress configuration | ||
ingress: | ||
# Enable ingress resource | ||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking should this enabled
conditional moved down to each resource?
So ingress.web.enabled
and ingress.flower.enabled
I may want web
enabled, but flower
ingress disabled if I have Celery
as executor for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aksakalli WDYT about this suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no option to disable flower
if you use CeleryExecutor
(unlike the stable/helm). I don't think it is common that someone would like to deploy it with an ingress record for webserver
but not for flower
.
I can make that change if you think that is a necessary use case.
I have another finding, it would be great to add this same thing in Notes.txt as well |
Indeed this was missing, I've added it! Thanks! |
anyone has any idea when it can get merged? eagerly waiting for this! |
Awesome work, congrats on your first merged pull request! |
For some reason #8777 did not include an ingress record in the helm chart for production. astronomer/airflow-chart has an ingress support but it has additional subdomain logic that is not needed for most of the deployments. Thus I adopted the templates from stable/airflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.