Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress to the helm chart #10064

Merged
merged 6 commits into from
Aug 15, 2020
Merged

Add ingress to the helm chart #10064

merged 6 commits into from
Aug 15, 2020

Conversation

aksakalli
Copy link
Contributor

For some reason #8777 did not include an ingress record in the helm chart for production. astronomer/airflow-chart has an ingress support but it has additional subdomain logic that is not needed for most of the deployments. Thus I adopted the templates from stable/airflow.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jul 30, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 30, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://apache-airflow-slack.herokuapp.com/

@kaxil kaxil requested a review from dimberman July 30, 2020 19:30
@kaxil
Copy link
Member

kaxil commented Jul 30, 2020

cc @schnie if you have time

# Ingress configuration
ingress:
# Enable ingress resource
enabled: false
Copy link
Contributor

@alikhtag alikhtag Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking should this enabled conditional moved down to each resource?
So ingress.web.enabled and ingress.flower.enabled
I may want web enabled, but flower ingress disabled if I have Celery as executor for example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aksakalli WDYT about this suggestion?

Copy link
Contributor Author

@aksakalli aksakalli Aug 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no option to disable flower if you use CeleryExecutor (unlike the stable/helm). I don't think it is common that someone would like to deploy it with an ingress record for webserver but not for flower.

I can make that change if you think that is a necessary use case.

@saikatharryc
Copy link

I have another finding, it would be great to add this same thing in Notes.txt as well

@alikhtag
Copy link
Contributor

alikhtag commented Aug 5, 2020

I have another finding, it would be great to add this same thing in Notes.txt as well

Indeed this was missing, I've added it! Thanks!

@saikatharryc
Copy link

anyone has any idea when it can get merged? eagerly waiting for this!

@kaxil kaxil changed the title adding ingress to the helm chart Add ingress to the helm chart Aug 15, 2020
@kaxil kaxil merged commit 4fc2536 into apache:master Aug 15, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 15, 2020

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants