Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PIP version is not pinned to 19.0.2 any more #10542

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 25, 2020

Fixes #10516


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member Author

potiuk commented Aug 25, 2020

Seems like removing pinning from PIP is not a problem for images. I figured we run all the tests and see :)

@potiuk
Copy link
Member Author

potiuk commented Aug 25, 2020

Right - it works @kaxil @dimberman @turbaszek @mik-laj -> no more PIP 19.02 pinning :)

@potiuk
Copy link
Member Author

potiuk commented Aug 25, 2020

This also shows the true power of the new CI system. If we did it with the previous ones, all jobs would be + 10 minutes. This time only the "wait jobs" were running for 10 minutes rather than usual 4 minutes, and all the rest took the same time as usual :)

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why it was pinned tbh

@potiuk
Copy link
Member Author

potiuk commented Aug 25, 2020

I think 1.19.03+ had problems with installing Airflow. But it's been fixed since possibly even 2 minor versions ago at 20.0 :).

@potiuk potiuk merged commit 018ae0e into apache:master Aug 25, 2020
@potiuk potiuk deleted the stop-pinning-pip-version branch August 25, 2020 13:46
potiuk added a commit to potiuk/airflow that referenced this pull request Sep 14, 2020
potiuk added a commit that referenced this pull request Sep 15, 2020
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
kaxil pushed a commit that referenced this pull request Nov 12, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
potiuk added a commit that referenced this pull request Nov 16, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
2 participants