Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add introduction to Stable RESTT API #10548

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Aug 25, 2020

Preview: https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/PolideaInternal/airflow/api-introduction/airflow/api_connexion/openapi/v1.yaml


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:docs labels Aug 25, 2020
@mik-laj mik-laj marked this pull request as ready for review August 25, 2020 12:01
@mik-laj mik-laj requested a review from kaxil August 25, 2020 12:01
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions or else LGTM

airflow/api_connexion/openapi/v1.yaml Outdated Show resolved Hide resolved
airflow/api_connexion/openapi/v1.yaml Outdated Show resolved Hide resolved
Comment on lines 38 to 42
The term `resource` refers to a single type of object in the Airflow metadata. An API is broken up by its
endpoint's corresponding resource.
The name of a resource is typically plural, and expressed in camelCase. Example: `jobGroups`.

Resource names are used as part of endpoint URLs, as well as in API parameters and responses.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The term `resource` refers to a single type of object in the Airflow metadata. An API is broken up by its
endpoint's corresponding resource.
The name of a resource is typically plural, and expressed in camelCase. Example: `jobGroups`.
Resource names are used as part of endpoint URLs, as well as in API parameters and responses.
The term `resource` refers to a single type of object in the Airflow metadata. An API is broken up by its
endpoint's corresponding resource.
The name of a resource is typically plural and expressed in camelCase. Example: `jobGroups`.
Resource names are used as part of endpoint URLs, as well as in API parameters and responses.

airflow/api_connexion/openapi/v1.yaml Outdated Show resolved Hide resolved

Note that you will need to pass an credentials data.

For e.g., here is how to pause a DAG with [curl](https://curl.haxx.se/), when basic authroization is used:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For e.g., here is how to pause a DAG with [curl](https://curl.haxx.se/), when basic authroization is used:
For e.g., here is how to pause a DAG with [curl](https://curl.haxx.se/), when basic authorization is used:

airflow/api_connexion/openapi/v1.yaml Outdated Show resolved Hide resolved
@mik-laj
Copy link
Member Author

mik-laj commented Aug 25, 2020

@kaxil All suggestion accepted.

@mik-laj mik-laj merged commit 5e82263 into apache:master Aug 25, 2020
@mik-laj mik-laj deleted the api-introduction branch August 25, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants