Untangle conf secrets deps #10559
Merged
Untangle conf secrets deps #10559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:secrets
provider:amazon
mik-laj
reviewed
Aug 25, 2020
mik-laj
reviewed
Aug 25, 2020
potiuk
force-pushed
the
untangle-conf-secrets-deps
branch
2 times, most recently
from
a7c59d1 to
de7b2d1
Compare
|
I think this way it is even nicer. |
kaxil
reviewed
Aug 25, 2020
potiuk
force-pushed
the
untangle-conf-secrets-deps
branch
5 times, most recently
from
e8c4da8 to
5e00771
Compare
|
I think it shoudl be ratrher nice now :) |
|
Taking a look at the changes and failed tests I would say that we may need to adjust mocking? |
I think it's better to keep backward compatibility and restore "get_connections" method in BaseHook :) |
potiuk
force-pushed
the
untangle-conf-secrets-deps
branch
from
5e00771 to
859c75b
Compare
|
I think this should work now :) |
potiuk
force-pushed
the
untangle-conf-secrets-deps
branch
from
859c75b to
bd07308
Compare
|
Or rather this time - there was some bad refactor breaking other tests :) |
kaxil
reviewed
Aug 26, 2020
kaxil
reviewed
Aug 26, 2020
kaxil
reviewed
Aug 26, 2020
kaxil
reviewed
Aug 26, 2020
potiuk
force-pushed
the
untangle-conf-secrets-deps
branch
from
bd07308 to
5a2babb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.