Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encode execution date in the Last Run link #10595

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

alexbegg
Copy link
Contributor

closes: #10434

The problem is when execution_date is passed in the URL unencoded for the "Last Run" link it results in an incorrect pendulum datetime when pendulum.parse() is used in the codebase. The time of the pendulum datetime gets incorrectly returned as 00:00:00 no matter what time the execution date has. URL encoding the execution_date value fixes the problem.

This was already fixed in all other places execution_date is used in URLs years ago with commit 9ec7f0f, but Last Run is more recent so this was missed.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Aug 27, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 27, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://apache-airflow-slack.herokuapp.com/

@kaxil kaxil merged commit 900f15a into apache:master Aug 27, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 27, 2020

Awesome work, congrats on your first merged pull request!

@kaxil kaxil added this to the Airflow 1.10.13 milestone Sep 25, 2020
kaxil pushed a commit that referenced this pull request Nov 19, 2020
kaxil pushed a commit that referenced this pull request Nov 20, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@alexbegg alexbegg deleted the encode-execution-date-last-run branch August 19, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last Run links on home page UI not correct with RBAC UI
2 participants