URL encode execution date in the Last Run link #10595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10434
The problem is when
execution_date
is passed in the URL unencoded for the "Last Run" link it results in an incorrectpendulum
datetime whenpendulum.parse()
is used in the codebase. The time of the pendulum datetime gets incorrectly returned as00:00:00
no matter what time the execution date has. URL encoding theexecution_date
value fixes the problem.This was already fixed in all other places
execution_date
is used in URLs years ago with commit 9ec7f0f, but Last Run is more recent so this was missed.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.