Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Data Catalog operators #13096

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Dec 16, 2020

Hello,

The library started throwing the following exception while resource are passed as as a dictionary.

google.api_core.exceptions.MethodNotImplemented: 501 Received http2 header with status: 404

We have a very old library - google-cloud-python 0.8.0 and the newest is 3.0.0, so we'll probably be able to delete it soon.
Best regards,
Kamil Breguła


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Dec 16, 2020
Copy link
Contributor

@TobKed TobKed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 16, 2020
@mik-laj mik-laj merged commit bcf7758 into apache:master Dec 16, 2020
@mik-laj mik-laj deleted the fix-datacatalog-operators branch December 16, 2020 10:42
kaxil pushed a commit that referenced this pull request Jan 21, 2021
(cherry picked from commit bcf7758)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants