-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string encoding in DockerOperator when using xcom / json #13536
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
@AlessioM can you please rebase on master? |
sorry for taking so long, done just now |
Many thanks for working on that issue ! |
Hi @AlessioM, thank you very much for this fix. |
I'm still running into #13487 in Airflow 2.0.1 - hope this gets merged soon. 🙏 |
@AlessioM you will need to rebase to fix the conflicts |
hi @kaxil @AlessioM @turbaszek is there a way to make progress with this fix? |
sorry,that it takes so long, hard to find time at the moment |
I am curious as to the issues/log messages being encountered here. I have had to patch our |
@AlessioM I will rebase it for you (as I added some changes in Docker Operator) - I am just about to FINALLY release RC2 of providers so I would love to get that one in. |
I rebased and pushed it @AlessioM :) (I also changed ADDITIONAL_INFO to CHANGELOG :) |
Co-authored-by: Jarek Potiuk <[email protected]>
I simplified it a bit more (there was no need to use logs, It's much simpler if we used already available array of potentially decoded lines and added more comprehensive tests |
Awesome work, congrats on your first merged pull request! |
Co-authored-by: Alessio Montuoro <[email protected]> Co-authored-by: Jarek Potiuk <[email protected]>
closes: #13535
fixes the xcom issue by decoding the byte array of the log file before submitting it to xcom