-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added copy connection action #13859
Added copy connection action #13859
Conversation
Can you add tests to avoid regression? |
Added test case to check copy connection with and without prefix with multi select. |
'aws_mongo', | ||
'aws_mongo__1', | ||
'aws_mongo__2', | ||
'aws_mongo__3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it fair to treat all aws_mongo
variants as essentially interchangeable in terms of numbering them? Would aws_mongo__1__1
make more sense than aws_mongo__3
to make clear that it's a copy of aws_mongo__1
? It doesn't look as nice, but it seems like people would copy aws_mongo__1
because they want a copy of that exact variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here in test case i have used '__1' as existing connection to test copy connection which were already copied connection and not renamed after copy.
For Pattern matching in RegEx we have used '__/d+$' to differentiate system(airflow) assigned suffix (we have used same Regex for Task and TaskGroup decorators). User can use single underscore '_' or '-' to assign number to connection name which will make it start from 1.
For Example
'mongo_1' -> 'mongo_1__1'
'mongo-1' -> 'mongo-1__1'
f859164
to
da7f5ae
Compare
Re-based PR. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Added copy connection action which attaches __suffix to duplicated connection.
Closes : #12401