Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable in-container health checks for ad-hoc containers #14536

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Mar 1, 2021

This slows things down a bit if we're trying to write scripts that can sometimes run multiple containers. The health of the containers is already checked by Docker, so we don't have to check it on our side every time.

Comparision:

$ time docker-compose run --rm -e CONNECTION_CHECK_MAX_COUNT=0 airflow-worker airflow celery
0.66s user 0.14s system 23% cpu 3.396 total
$ time docker-compose run --rm -e CONNECTION_CHECK_MAX_COUNT=0 airflow-worker airflow celery
0.66s user 0.14s system 22% cpu 3.576 total
$ time docker-compose run --rm -e CONNECTION_CHECK_MAX_COUNT=0 airflow-worker airflow celery
0.61s user 0.13s system 22% cpu 3.210 total
$ time docker-compose run --rm -e CONNECTION_CHECK_MAX_COUNT=1 airflow-worker airflow celery
0.67s user 0.18s system 19% cpu 4.456 total
$ time docker-compose run --rm -e CONNECTION_CHECK_MAX_COUNT=1 airflow-worker airflow celery
0.63s user 0.14s system 18% cpu 4.182 total
$ time docker-compose run --rm -e CONNECTION_CHECK_MAX_COUNT=1 airflow-worker airflow celery
0.65s user 0.15s system 18% cpu 4.373 total

Part of: #11161


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@mik-laj mik-laj changed the title Disable health checks for ad-hoc containers Disable in-container health checks for ad-hoc containers Mar 1, 2021
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 1, 2021
@mik-laj mik-laj merged commit 164ac4d into apache:master Mar 1, 2021
potiuk pushed a commit that referenced this pull request Mar 3, 2021
Co-authored-by: Kamil Breguła <[email protected]>
(cherry picked from commit 164ac4d)
potiuk pushed a commit that referenced this pull request Mar 3, 2021
Co-authored-by: Kamil Breguła <[email protected]>
(cherry picked from commit 164ac4d)
potiuk pushed a commit that referenced this pull request Mar 3, 2021
Co-authored-by: Kamil Breguła <[email protected]>
(cherry picked from commit 164ac4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants