Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chart to work with custom cluster domains #15640

Merged
merged 2 commits into from
May 4, 2021

Conversation

jedcunningham
Copy link
Member

K8s clusters can use a different cluster domain than the default
cluster.local. This change will make the chart compatible with those
clusters as well.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label May 3, 2021
@jedcunningham jedcunningham changed the title Dont use the default k8s cluster domain in chart Allow chart to work with custom cluster domains May 3, 2021
@github-actions
Copy link

github-actions bot commented May 3, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 3, 2021
K8s clusters can use a different cluster domain than the default
`cluster.local`. This change will make the chart compatible with those
clusters as well.
@jedcunningham jedcunningham requested a review from kaxil May 4, 2021 15:30
@kaxil kaxil merged commit 59be278 into apache:master May 4, 2021
@kaxil kaxil deleted the cluster_domain branch May 4, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants