Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error mount temporary directory when using DockerOperator #17230

Closed
wants to merge 1 commit into from

Conversation

nguyenmphu
Copy link

@nguyenmphu nguyenmphu commented Jul 26, 2021

By default, when generating a task instance, DockerOperator will create a new temporary directory and mount it to the Docker temporary directory. But in the Airflow version 2.1, DockerOperator uses mounts instead of volumes attributes to mount that temporary directory. With the mounts attribute, the Docker engine does not automatically create a new directory if its path does not exist in the Docker host, but generates an error.
Here is the doc: https://docs.docker.com/storage/bind-mounts/#differences-between--v-and---mount-behavior


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 26, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jul 26, 2021

This has already been addressed in #16932 . The updated docker provider will be released in a few days.

@potiuk potiuk closed this Jul 26, 2021
@potiuk potiuk added the duplicate Issue that is duplicated label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers duplicate Issue that is duplicated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants