Improve message and documentation around moved data #19453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
bbovenzi,
kaxil,
mik-laj,
ryanahamilton and
vikramkoka
as code owners
boring-cyborg
bot
added
area:UI
uranusjr
reviewed
Nov 7, 2021
|
Should we merge that one? |
kaxil
reviewed
Nov 8, 2021
kaxil
reviewed
Nov 8, 2021
|
Hi, can we add some simple logging message to code ? |
|
potiuk
force-pushed
the
add-more-context-and-helpful-advice-for-post-migration-actions
branch
from
eaf2d41 to
f6e60a3
Compare
|
Thanks for the commends @jedcunningham @uranusjr @kaxil - I think it's much better now :) Proposal: if it won't make it in 2.2.2 (I doubt now) - then we can cherry-pick that one to v2-2-test and build docs using it so that at least the docs are published with 2.2.2 release :) |
In Airflow 2.2.2 we introduced a fix in apache#18953 where the corrupted data was moved to a separate table. However some of our users (rightly) might not have the context. We've never had anything like that before, so the users who treat Airflow DB as black-boxes might get confused on what the error means and what they should do in this case. You can see it in apache#19440 converted into discussion apache#19444 and apache#19421 indicate that the message is a bit unclear for users. This PR attempts to improve that it adds `upgrading` section to our documentation and have the message link to it so that rather than asking questions in the issues, users can find context and answers what they should do in our docs. It also guides the users who treat Airflow DB as "black-box" on how they can use their tools and airflow db shell to fix the problem.
potiuk
force-pushed
the
add-more-context-and-helpful-advice-for-post-migration-actions
branch
from
f6e60a3 to
5ed9c43
Compare
jedcunningham
approved these changes
Nov 10, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Jed Cunningham <[email protected]>
potiuk
deleted the
add-more-context-and-helpful-advice-for-post-migration-actions
branch
kaxil
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Improve message and documentation around moved data In Airflow 2.2.2 we introduced a fix in #18953 where the corrupted data was moved to a separate table. However some of our users (rightly) might not have the context. We've never had anything like that before, so the users who treat Airflow DB as black-boxes might get confused on what the error means and what they should do in this case. You can see it in #19440 converted into discussion #19444 and #19421 indicate that the message is a bit unclear for users. This PR attempts to improve that it adds `upgrading` section to our documentation and have the message link to it so that rather than asking questions in the issues, users can find context and answers what they should do in our docs. It also guides the users who treat Airflow DB as "black-box" on how they can use their tools and airflow db shell to fix the problem. (cherry picked from commit de43fb3)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Airflow 2.2.1 we introduced a fix in #18953 where the corrupted
data was moved to a separate table. However some of our users
(rightly) might not have the context. We've never had anything
like that before, so the users who treat Airflow DB as
black-boxes might get confused on what the error means and what
they should do in this case.
You can see it in #19440 converted into discussion #19444 and #19421
indicate that the message is a bit unclear for users. This PR attempts to
improve that it adds
upgradingsection to our documentation and have themessage link to it so that rather than asking questions in the issues,
users can find context and answers what they should do in our docs.
It also guides the users who treat Airflow DB as "black-box" on how they
can use their tools and airflow db shell to fix the problem.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.