Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MyPy errors in leveldb #20222

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 11, 2021

Part of #19891


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested a review from turbaszek as a code owner December 11, 2021 19:19
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Dec 11, 2021
@potiuk potiuk requested review from mik-laj and dstandish December 11, 2021 19:19
@potiuk potiuk force-pushed the fix-mypy-google-providers-leveldb branch from 690892a to 4dededb Compare December 12, 2021 11:01
@potiuk potiuk added the mypy Fixing MyPy problems after bumpin MyPy to 0.990 label Dec 13, 2021
@potiuk
Copy link
Member Author

potiuk commented Dec 14, 2021

Super small one

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 15, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit c4b3694 into apache:main Dec 15, 2021
@potiuk potiuk deleted the fix-mypy-google-providers-leveldb branch December 15, 2021 13:04
@kaxil kaxil added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2022
@potiuk potiuk restored the fix-mypy-google-providers-leveldb branch April 26, 2022 20:51
@potiuk potiuk deleted the fix-mypy-google-providers-leveldb branch July 29, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) mypy Fixing MyPy problems after bumpin MyPy to 0.990 okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants