Dataplex operators #20377

wojsamjan · 2021-12-17T13:29:49Z

Add support for Google Dataplex. Includes operators, sensors, hooks, example dags, tests and docs.

Authored-by: Wojciech Januszek [email protected]

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

airflow/providers/google/cloud/hooks/dataplex.py

potiuk · 2021-12-23T14:24:29Z

airflow/providers/google/cloud/sensors/dataplex.py

+        if task_status == TaskState.DELETING:
+            raise AirflowException(f"Task is going to be deleted {self.dataplex_task_id}")
+
+        self.log.info(f"Current status of the Dataplex task {self.dataplex_task_id} => {task_status}")


NIT: We prefer to use "%" format for logs, otherwise the string interpolation will be executed indepnendently of the logging level set (yep. I know INFO is default, but it can be changed to ERROR and then it is unnecessary to interpolate it)

airflow/providers/google/cloud/hooks/dataplex.py

josh-fell · 2021-12-27T04:18:44Z

airflow/providers/google/cloud/example_dags/example_dataplex.py

+# [END howto_dataplex_configuration]
+
+with models.DAG(
+    "example_dataplex", start_date=datetime.datetime(2021, 1, 1), schedule_interval="@once"


Would you mind adding catchup=False? This has been added to all example DAGs to ward off any unexpected DagRuns for users if they copy this DAG for their use and modify start_date or schedule_interval without knowing about the catchup functionality.

josh-fell · 2021-12-27T04:20:44Z

airflow/providers/google/cloud/hooks/dataplex.py

+
+class DataplexHook(GoogleBaseHook):
+    """Hook for Google Dataplex."""
+


Could you add parameter/type info in the docstring for this hook? It would be great to see these in the Airflow API documentation which is generated by the docstring.

josh-fell · 2021-12-27T04:24:42Z

airflow/providers/google/cloud/hooks/dataplex.py

+            delegate_to=delegate_to,
+            impersonation_chain=impersonation_chain,
+        )
+        self.api_key = API_KEY


Is this something that users should be able to configure in an Airflow Connection and passed to the hook or is the idea that this key must be configured within the environment itself?

If the latter, should there be a validation here to check that the api_key was provided rather than have the "INVALID API KEY" default value? Or is this default value checked somewhere downstream?

In Airflow Connection I set standard Keyfile Path - pointing to: /files/airflow-breeze-config/keys/<KEY_FILE_NAME>.json On the other hand we have to set an API Key in Credentials on GCP side to connect with discovery API - otherwise we can not perform operations.
I have not seen an option to set this value inside the Airflow Connection - so I used an environment variable. I am open to any suggestions about where it should be stored and any other improvements.

josh-fell · 2021-12-27T04:30:56Z

airflow/providers/google/cloud/operators/dataplex.py

+        self.impersonation_chain = impersonation_chain
+        self.asynchronous = asynchronous
+
+    def execute(self, context: dict) -> dict:


Now that 2.2.3 has been released, typing for context can be:

from typing import TYPE_CHECKING if TYPE_CHECKING: from airflow.utils.context import Context ... def execute(self, context: "Context") -> dict: ...

This can be applied to all of the operators too.

TIL 🚀 Thanks @josh-fell

Yeah. I applied it globally during the Xmas break. Just wonder. Maybe we should add a pre-commit checking if the "old ways" are still used. WDYT @turbaszek @josh-fell ?

+1 Definitely worth automating.

josh-fell · 2021-12-27T04:31:58Z

airflow/providers/google/cloud/sensors/dataplex.py

+        self.delegate_to = delegate_to
+        self.impersonation_chain = impersonation_chain
+
+    def poke(self, context: dict) -> bool:


Same comment here about context typing.

turbaszek · 2022-01-05T15:54:02Z

airflow/providers/google/cloud/hooks/dataplex.py

+from airflow.exceptions import AirflowException
+from airflow.providers.google.common.hooks.base_google import GoogleBaseHook
+
+API_KEY = os.environ.get("GCP_API_KEY", "INVALID API KEY")


Is that necessary?

Yes, API Key is needed to perform operations on dataplex

The authentication should be provided via dedicated connection. And as far as I remember GoogleBaseHook already provides all authentication methods supported by Google. If this is something only Dataplex specific we should introduce a new connection type. In this way users will have full control over the credentials. See for example google ads:

airflow/airflow/providers/google/ads/hooks/ads.py

Lines 43 to 68 in 7947b72

This hook requires two connections:

- gcp_conn_id - provides service account details (like any other GCP connection)

- google_ads_conn_id - which contains information from Google Ads config.yaml file

in the ``extras``. Example of the ``extras``:

.. code-block:: json

{

"google_ads_client": {

"developer_token": "{{ INSERT_TOKEN }}",

"path_to_private_key_file": null,

"delegated_account": "{{ INSERT_DELEGATED_ACCOUNT }}"

}

}

The ``path_to_private_key_file`` is resolved by the hook using credentials from gcp_conn_id.

https://developers.google.com/google-ads/api/docs/client-libs/python/oauth-service

.. seealso::

For more information on how Google Ads authentication flow works take a look at:

https://developers.google.com/google-ads/api/docs/client-libs/python/oauth-service

.. seealso::

For more information on the Google Ads API, take a look at the API docs:

https://developers.google.com/google-ads/api/docs/start

Discussed within the team, for now I am going to remove API_KEY - it was needed for development purposes. Once the Dataplex API will be publicly available it will not be needed any more. I will commit changes and then draft this PR.

github-actions · 2022-02-27T00:22:47Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

wojsamjan · 2022-03-10T13:36:50Z

@mik-laj @vikramkoka guys could you do a review, would be great. Thank you

turbaszek

Looks good to me 👌

github-actions · 2022-03-11T22:28:39Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

potiuk · 2022-03-14T01:34:17Z

It needs at least rebase and checking if the errors were accidental.

wojsamjan requested review from mik-laj, turbaszek and vikramkoka as code owners December 17, 2021 13:29

boring-cyborg bot added area:providers kind:documentation provider:google Google (including GCP) related issues labels Dec 17, 2021

eladkal reviewed Dec 22, 2021

View reviewed changes

airflow/providers/google/cloud/hooks/dataplex.py Outdated Show resolved Hide resolved

potiuk reviewed Dec 23, 2021

View reviewed changes

josh-fell reviewed Dec 27, 2021

View reviewed changes

eladkal mentioned this pull request Dec 31, 2021

[Part 1]: Add hook for integrating with Google Calendar #20542

Merged

turbaszek reviewed Jan 5, 2022

View reviewed changes

wojsamjan marked this pull request as draft January 12, 2022 14:28

github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 27, 2022

wojsamjan force-pushed the dataplex-operators branch 6 times, most recently from 6bf36e6 to 904f091 Compare March 9, 2022 09:39

wojsamjan force-pushed the dataplex-operators branch from 904f091 to e7b7abf Compare March 9, 2022 11:55

eladkal removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 9, 2022

wojsamjan force-pushed the dataplex-operators branch from e7b7abf to de5162b Compare March 9, 2022 13:02

wojsamjan marked this pull request as ready for review March 10, 2022 09:19

wojsamjan force-pushed the dataplex-operators branch 2 times, most recently from 4eda728 to d93fbb5 Compare March 10, 2022 10:29

wojsamjan force-pushed the dataplex-operators branch from d93fbb5 to 14c857d Compare March 11, 2022 07:33

turbaszek approved these changes Mar 11, 2022

View reviewed changes

github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 11, 2022

Wojciech Januszek added 14 commits March 14, 2022 09:09

Add dataplex operators

9d47be5

Add impersonation_chain support. Implement sensor tests

637e783

Fix unused imports

ae7d274

Update logging. Add type info in hook & TYPE_CHECKING

d385ee2

Remove API_KEY

2d0c04e

Rewrite from raw API to Python client

f2850dc

Add links

d53678f

Update links

7747a7e

Update unit tests

8aae7c6

Remove types. Update system tests

b5d0f2b

Fix static checks

da2e7fa

Remove constant timeout. Fix metadata & timeout type

06d5186

Revert changed setup

36e0092

Fix sensor test

96a62fd

wojsamjan force-pushed the dataplex-operators branch from 14c857d to 96a62fd Compare March 14, 2022 09:09

turbaszek approved these changes Mar 14, 2022

View reviewed changes

turbaszek merged commit 87c1246 into apache:main Mar 14, 2022

potiuk mentioned this pull request Mar 15, 2022

Status of testing Providers that were prepared on March 15, 2022 #22264

Closed

41 tasks

ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dataplex operators #20377

Dataplex operators #20377

wojsamjan commented Dec 17, 2021

potiuk Dec 23, 2021

wojsamjan Jan 3, 2022

josh-fell Dec 27, 2021

josh-fell Dec 27, 2021

josh-fell Dec 27, 2021

wojsamjan Jan 5, 2022

josh-fell Dec 27, 2021

turbaszek Jan 3, 2022

potiuk Jan 3, 2022

josh-fell Jan 6, 2022

josh-fell Dec 27, 2021

turbaszek Jan 5, 2022

wojsamjan Jan 7, 2022

turbaszek Jan 8, 2022 •

edited

Loading

wojsamjan Jan 12, 2022

github-actions bot commented Feb 27, 2022

wojsamjan commented Mar 10, 2022

turbaszek left a comment

github-actions bot commented Mar 11, 2022

potiuk commented Mar 14, 2022


		class DataplexHook(GoogleBaseHook):
		"""Hook for Google Dataplex."""

	This hook requires two connections:

	- gcp_conn_id - provides service account details (like any other GCP connection)
	- google_ads_conn_id - which contains information from Google Ads config.yaml file
	in the ``extras``. Example of the ``extras``:

	.. code-block:: json

	{
	"google_ads_client": {
	"developer_token": "{{ INSERT_TOKEN }}",
	"path_to_private_key_file": null,
	"delegated_account": "{{ INSERT_DELEGATED_ACCOUNT }}"
	}
	}

	The ``path_to_private_key_file`` is resolved by the hook using credentials from gcp_conn_id.
	https://developers.google.com/google-ads/api/docs/client-libs/python/oauth-service

	.. seealso::
	For more information on how Google Ads authentication flow works take a look at:
	https://developers.google.com/google-ads/api/docs/client-libs/python/oauth-service

	.. seealso::
	For more information on the Google Ads API, take a look at the API docs:
	https://developers.google.com/google-ads/api/docs/start

Dataplex operators #20377

Dataplex operators #20377

Conversation

wojsamjan commented Dec 17, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turbaszek Jan 8, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 27, 2022

wojsamjan commented Mar 10, 2022

turbaszek left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 11, 2022

potiuk commented Mar 14, 2022

turbaszek Jan 8, 2022 •

edited

Loading