Fix trigger dag redirect from task instance log view #21239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When triggering a dag run from log view, we are redirected back to log view and execution_date is not populated. This produces an error. To resolve this we should not attempt to parse execution_date when it's empty.
dstandish
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
bbovenzi
approved these changes
Jan 31, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
HaloKo4
reviewed
Jan 31, 2022
| @@ -1377,7 +1377,7 @@ def log(self, session=None): | |||
| dag_id = request.args.get('dag_id') | |||
| task_id = request.args.get('task_id') | |||
| execution_date = request.args.get('execution_date') | |||
| dttm = timezone.parse(execution_date) | |||
| dttm = timezone.parse(execution_date) if execution_date else None | |||
There was a problem hiding this comment.
isn't execution date deprecated and replaced with data interval?
There was a problem hiding this comment.
Eventually we want to change this to use run_id instead so let’s not bother changing it. This is considered internal and execution_date is only a variable name.
uranusjr
approved these changes
Feb 1, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 23, 2022
(cherry picked from commit fd8f21f)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit fd8f21f)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 26, 2022
(cherry picked from commit fd8f21f)
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When triggering a dag run from log view, we are redirected back to log view and
execution_date is not populated. This produces an error.
To resolve this we should not attempt to parse execution_date when it's empty.