Prepare to switch to debian bullseye #21522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
mik-laj,
jedcunningham and
kaxil
as code owners
boring-cyborg
bot
added
area:dev-tools
area:production-image
|
Testing "main" build here: https://github.com/potiuk/airflow/actions/runs/1830182817 . Looks good so far. |
potiuk
force-pushed
the
prepare-for-bullseye-switch
branch
2 times, most recently
from
a556b3d to
d8ad1a8
Compare
mik-laj
reviewed
Feb 11, 2022
mik-laj
reviewed
Feb 11, 2022
mik-laj
reviewed
Feb 11, 2022
mik-laj
reviewed
Feb 11, 2022
potiuk
force-pushed
the
prepare-for-bullseye-switch
branch
from
54c2c41 to
67b95c1
Compare
|
All shoud be addressed @mik-laj ! |
|
Preparation complete! |
jedcunningham
approved these changes
Feb 11, 2022
docs/docker-stack/docker-examples/customizing/github-different-repository.sh
Show resolved
Hide resolved
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
force-pushed
the
prepare-for-bullseye-switch
branch
2 times, most recently
from
0de0175 to
f0287bf
Compare
|
It seems a bit slimmer now ( the only "buster/bullseye" distinction is in the build scripts now - but not in the image). Testing the "main" build here as well: https://github.com/potiuk/airflow/actions/runs/1832053186 |
In order to switch smoothly to Debian Bullseye we need to run a few more tests and see if the performance impact we observe is consistent (the tests with Public Runners seems to be killed more frequently there). This requires some preparatory work - namely add the capability of overriding the DEBIAN_VERSION via PR - because otherwise Build Images workflow that runs from main will build buster images until the change is actually merged. This change introduce this capability without switching to Bullseye yet - it will unblock the actual PR that will make the change from failing in PRs though.
potiuk
force-pushed
the
prepare-for-bullseye-switch
branch
from
f0287bf to
c9fb13c
Compare
|
And of course a typo: https://github.com/potiuk/airflow/actions/runs/1832116945 . Good I checked. |
|
All Green ! |
mik-laj
added a commit
to mik-laj/airflow
that referenced
this pull request
Feb 12, 2022
potiuk
pushed a commit
that referenced
this pull request
Feb 12, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 19, 2022
We are preparing to switch from Buster to Bullseye and this is the second change that is needed (following apache#21522). This change allows to choose whether we want to use Buster or Bullseye images as a base. We need to be able to choose, because: 1) we want to keep backwards compatibility and continue our users to build Buster-base images 2) we cannot yet fully switch to Bullseye because MsSQL's odbc driver does not yet support Bullseye and we reached out to mysql maintainers to learn about their plans to make the decision on when and how we are going to support Bullseye and MSSQL. Details of this discussion are in: https://github.com/MicrosoftDocs/sql-docs/issues/7255#issuecomment-1037097131 This PR adds the capability of choosing the DEBIAN_VERSION in Breeze when building images but does not yet switch from Buster to Bullseye
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 26, 2022
We are preparing to switch from Buster to Bullseye and this is the second change that is needed (following apache#21522). This change allows to choose whether we want to use Buster or Bullseye images as a base. We need to be able to choose, because: 1) we want to keep backwards compatibility and continue our users to build Buster-base images 2) we cannot yet fully switch to Bullseye because MsSQL's odbc driver does not yet support Bullseye and we reached out to mysql maintainers to learn about their plans to make the decision on when and how we are going to support Bullseye and MSSQL. Details of this discussion are in: https://github.com/MicrosoftDocs/sql-docs/issues/7255#issuecomment-1037097131 This PR adds the capability of choosing the DEBIAN_VERSION in Breeze when building images but does not yet switch from Buster to Bullseye
potiuk
added a commit
that referenced
this pull request
Feb 28, 2022
…21546) We are preparing to switch from Buster to Bullseye and this is the second change that is needed (following #21522). This change allows to choose whether we want to use Buster or Bullseye images as a base. We need to be able to choose, because: 1) we want to keep backwards compatibility and continue our users to build Buster-base images 2) we cannot yet fully switch to Bullseye because MsSQL's odbc driver does not yet support Bullseye and we reached out to mysql maintainers to learn about their plans to make the decision on when and how we are going to support Bullseye and MSSQL. Details of this discussion are in: https://github.com/MicrosoftDocs/sql-docs/issues/7255#issuecomment-1037097131 This PR adds the capability of choosing the DEBIAN_VERSION in Breeze when building images but does not yet switch from Buster to Bullseye
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to switch smoothly to Debian Bullseye we need to run a
few more tests and see if the performance impact we observe is
consistent (the tests with Public Runners seems to be killed more
frequently there).
This requires some preparatory work - namely add the capability
of overriding the DEBIAN_VERSION via PR - because otherwise
Build Images workflow that runs from main will build buster images
until the change is actually merged.
This change introduce this capability without switching to
Bullseye yet - it will unblock the actual PR that will make the
change from failing in PRs though.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.