Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-21603] Reenabled passing cmd configuration #21604

Conversation

2ps
Copy link

@2ps 2ps commented Feb 16, 2022

Problem?

Not including _cmd configuration options broke configuration for
sql_alchemy_conn_cmd and fernet_key_cmd which caused all tasks to
fail with a mysterious sqlite error.

Solution!

Reenabled including _cmd configuration values when creating the
temporary configuration used to run tasks.

Problem?

Not including `_cmd` configuration options broke configuration for
`sql_alchemy_conn_cmd` and `fernet_key_cmd` which caused all tasks to
fail with a mysterious sqlite error.

Solution!

Reenabled including `_cmd` configuration values when creating the
temporary configuration used to run tasks.
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Feb 16, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 16, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@ashb
Copy link
Member

ashb commented Feb 17, 2022

Please tell us how to reproduce this when it currently causing a problem.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Agree with @ashb - we need to know what problems you had how you diagnozed that this was it and how the change is fixing it.

@ashb
Copy link
Member

ashb commented Feb 18, 2022

Closing in favour of 21539

@ashb ashb closed this Feb 18, 2022
@2ps
Copy link
Author

2ps commented Feb 18, 2022

@ashb -- jsut as an FYI--we referenced an issue that we opened that would describe the problem that we were creating. In the future, would you like us to include the issue description in both the PR and the issue, or just the issue?

@ashb
Copy link
Member

ashb commented Feb 18, 2022

I didn't notice at first the issue number in the title as GitHub didn't link it for me.

If you are also going to open a PR, you can skip the issue and directly describe the problem in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants