Fix RedshiftDataOperator and update doc #22157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon
potiuk
approved these changes
Mar 10, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
josh-fell
reviewed
Mar 10, 2022
Comment on lines
-44
to
-51
| @dag( | ||
| dag_id='example_redshift_data', | ||
| schedule_interval=None, | ||
| start_date=datetime(2021, 1, 1), | ||
| dagrun_timeout=timedelta(minutes=60), | ||
| tags=['example'], | ||
| catchup=False, | ||
| ) |
There was a problem hiding this comment.
Why update away from the @dag decorator? More curiosity than a suggestion.
There was a problem hiding this comment.
Good question. We (AWS) are trying to be consistent across the Amazon providers package and decided to go with this format
josh-fell
reviewed
Mar 10, 2022
airflow/providers/amazon/aws/example_dags/example_redshift_data_execute_sql.py
Outdated
Show resolved
Hide resolved
vincbeck
force-pushed
the
redshift-data-fix
branch
from
009e8a5 to
8cd5098
Compare
eladkal
reviewed
Mar 10, 2022
docs/apache-airflow-providers-amazon/operators/redshift_data.rst
Outdated
Show resolved
Hide resolved
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing
RedshiftDataOperatoroperator as part of #22063 verification process I found out some bugs. The bugs are, for all optional parameters as part ofRedshiftDataOperator, they should not be passed down to the boto3 client if no value is specified. Otherwise, such error message are thrownInvalid type for parameter Parameters, value: None, type: <class 'NoneType'>, valid types: <class 'list'>, <class 'tuple'>.I also updated the doc and sample dag for
RedshiftDataOperator