Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and disallow a relative path for sqlite #22530

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Check and disallow a relative path for sqlite #22530

merged 1 commit into from
Mar 25, 2022

Conversation

yenchenLiu
Copy link
Contributor

related: #22014

Since flask-session was added in version 2.2.4, Flask needs to connect to the database.
However, when establishing a database connection, if a relative path is used, DB path will not be correctly used. So when building a Flask app, we check if the database path is a relative path, and if so, an error message will be displayed.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 25, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 25, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Mar 25, 2022

This is really cool find @yenchenLiu - thanks for finding out the root cause ! It was a difficult one!

@potiuk potiuk added this to the Airflow 2.2.5 milestone Mar 25, 2022
@potiuk potiuk merged commit 96e880d into apache:main Mar 25, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 25, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants