[AIRFLOW-1159] upgrading to docker >2.0

[elipapa]

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Airflow JIRA issues and references them in the PR title.
  • https://issues.apache.org/jira/browse/AIRFLOW-1159
  • https://issues.apache.org/jira/browse/AIRFLOW-944

Description

• Here are some details about my PR, including screenshots of any UI changes:

docker-py has been renamed to docker and introduced a few breaking changes http://docker-py.readthedocs.io/en/stable/change-log.html

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

the functionality is not altered/improved and no new test is required.

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[mention-bot]

@elipapa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @asnir, @bolkedebruin and @r39132 to be potential reviewers.

[saguziel]

@elipapa pls fix tests

[elipapa]

tests seem to fail b/c of a pre-existing cache. how can one clear the cache on travis?

…

On Fri, Jun 23, 2017 at 3:35 AM, Alex Guziel ***@***.***> wrote: @elipapa <https://github.com/elipapa> pls fix tests — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2369 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG34iVFsSrMy3snt0PE1QR0z6hg_kSWks5sGySDgaJpZM4N7yli> .

[r39132]

@elipapa please rebase. I will take a look after.

[codecov-io]

Codecov Report

Merging #2369 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2369   +/-   ##
======================================
  Coverage    75.9%   75.9%           
======================================
  Files         197     197           
  Lines       14702   14702           
======================================
  Hits        11159   11159           
  Misses       3543    3543

Impacted Files	Coverage Δ
airflow/hooks/docker_hook.py	91.89% <100%> (ø)	⬆️
airflow/operators/docker_operator.py	97.67% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67c13e...53e8518. Read the comment docs.

[Fokko]

We already switched a couple of times between docker and docker-py, but I can't recall the nuances. @benjaminsims ?

[elipapa]

@Fokko actually there are no differences: it's the same official docker python SDK package, but it has been renamed after v2.0.
The official documentation (https://docker-py.readthedocs.io/en/stable/) now dictates the install to be pip install docker instead of pip install docker-py

[Fokko]

Ack, thanks. It looks like 3.3.0 is the current version. Maybe bump it to 3+ right away?

https://pypi.org/project/docker/

[elipapa]

That's what's already happening.
pip will by default use the most recent stable version (which is 3.3.0 at the moment). I have only placed the requirements that it is >=2.0 but not fixed it at that.

You can see it in the travis log:

[ron819]

@elipapa any progress with this?

[ashb]

Fixed by #4049 or #3407