Replace urlparse with urlsplit

[westonkl]

Replaces urlparse with urlsplit as urlsplit is faster and lighterweight.

urlsplit is similar to urlparse(), but does not split the params from the URL. The params functionality allows you to put variables in the url. This should generally be used instead of urlparse().

urlsplit: (addressing scheme, network location, path, query, fragment identifier)
urlparse: (addressing scheme, network location, path, params, query, fragment identifier)

---

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected]
  Slack: https://s.apache.org/airflow-slack

[BobDu]

why are you say urlsplit is faster and lighterweight?
python official docs not record it, even, I didn't find any other information recommending use urlsplit.

[westonkl]

why are you say urlsplit is faster and lighterweight? python official docs not record it, even, I didn't find any other information recommending use urlsplit.

Its not much faster and maybe its a bit overselling it to be calling it lighterweight, but it is faster as it doesn't try to parse the url for params. The second sentence here of python docs on it says "This should generally be used instead of urlparse()".

[westonkl]

Btw there were other files that could have this change applied to them, but I just wanted to see if it was a wanted change before I updated them too.

[BobDu]

why are you say urlsplit is faster and lighterweight? python official docs not record it, even, I didn't find any other information recommending use urlsplit.

Its not much faster and maybe its a bit overselling it to be calling it lighterweight, but it is faster as it doesn't try to parse the url for params. The second sentence here of python docs on it says "This should generally be used instead of urlparse()".

Emm, if the more recent URL syntax allowing parameters to be applied to each segment of the path portion of the URL (see [RFC 2396](https://datatracker.ietf.org/doc/html/rfc2396.html)) is wanted.

But, It seems we don't need support RFC 2396 update syntax?

[uranusjr]

I don’t think there’s any perceptible performance difference between urlsplit and urlparse, but the former is indeed better; literally nobody uses RFC 2396 now.

[eladkal]

there are more usages for this in the project. Should we adress them as well?

[westonkl]

there are more usages for this in the project. Should we adress them as well?

Yup, I can add them into this pr

[BobDu]

some small ideas, If we replace all urlparse to urlsplit, can we add some lint rule in pre-commit to prevent new code use urlparse again in future.

[dstandish]

looks like something went wrong with your git operations. you have a lot of unrelated changes.

[westonkl]

Yeah I just saw, should I create a temp branch and cherry pick my commits?

[dstandish]

Yeah I just saw, should I create a temp branch and cherry pick my commits?

any strategy that works is fine :)

and yeah that sounds like a working strategy.

[westonkl]

looks like something went wrong with your git operations. you have a lot of unrelated changes.

This was fixed, could you review again?

[eladkal]

Needs rebase and resolving conflicts

resolved

[boring-cyborg]

Awesome work, congrats on your first merged pull request!