Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to isort version 5.11.2 in pre-commit #28652

Merged
merged 3 commits into from
Dec 31, 2022
Merged

Revert to isort version 5.11.2 in pre-commit #28652

merged 3 commits into from
Dec 31, 2022

Conversation

dstandish
Copy link
Contributor

Hopefully fix broken main

@dstandish dstandish removed the request for review from josh-fell December 30, 2022 18:14
potiuk
potiuk approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@dstandish
Copy link
Contributor Author

i'm still working on it. 🤞 indeed

@dstandish
Copy link
Contributor Author

when i reference pyproject toml, it doesn't seem to respect skip and modifies tests/decorators/test_python.py

@dstandish
Copy link
Contributor Author

same with skip_glob

@dstandish
Copy link
Contributor Author

ok... new tactic... back to 5.11.2

@dstandish dstandish changed the title Fix isort pre-commit issue by specifying pyproject.toml Revert to isort version 5.11.2 in pre-commit Dec 31, 2022
@dstandish dstandish merged commit 378c8fa into apache:main Dec 31, 2022
@dstandish dstandish deleted the fix-isort-pre-commit branch December 31, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@uranusjr uranusjr Awaiting requested review from uranusjr

Assignees
No one assigned
Labels
area:dev-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstandish @potiuk