FixGoogleCampaignManagerReportSensor
with QUEUED
status
#28735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Campaign Manager 360, in their latest api version (v4), introduced a new status that a report file can return. As v4 is the only version that is currently supported, we should update the sensor to work well with these changes.
Currently, sensor only checks if file status is different from
![image](https://user-images.githubusercontent.com/79157078/210618385-5f284e9a-93b2-45ef-818d-ac9db8e9b7a0.png)
PROCESSING
. As You can see in the official documentation there is a status calledQUEUED
which also means that the report file is not yet picked up for processing. From my experience this status can be returned when API is globally under heavy load or if You are generating multiple reports at once as a single user. Right now sensor exits when finding QUEUED status:and it should wait for the file to be processed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.