Add prettier formatting for www #29768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
potiuk,
ashb,
jedcunningham,
ryanahamilton and
bbovenzi
as code owners
boring-cyborg
bot
added
area:dev-tools
area:UI
pierrejeambrun
force-pushed
the
add-prettier-for-formatting
branch
from
c884366 to
c82b6d6
Compare
potiuk
approved these changes
Feb 25, 2023
pierrejeambrun
commented
Feb 25, 2023
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
This is necessary because prettier is otherwise using the default config in .editorconfig that will format with an indent size of 4 json files.
| .mypy_cache/ | ||
| templates/**/*.html | ||
| dist/ | ||
| *.md |
There was a problem hiding this comment.
Don't prettier format yaml and md. Those are handled by other dedicated pre-commit hook.
pierrejeambrun
added
the
changelog:skip
bbovenzi
requested changes
Feb 27, 2023
There was a problem hiding this comment.
Looking good! Let's update the contributing documentation too.
pierrejeambrun
force-pushed
the
add-prettier-for-formatting
branch
3 times, most recently
from
8a18ac3 to
8d549ef
Compare
bbovenzi
approved these changes
Feb 27, 2023
pierrejeambrun
force-pushed
the
add-prettier-for-formatting
branch
from
8d549ef to
40dfa42
Compare
|
(Kicking this to 2.6, a ton of churn for no functional differences) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Formatting with eslint is too permissive. 2 different formatting style can be considered 'valid' for eslint but quite different in practice. Also formatting with eslint is not the most common so switching for prettier might be helpful. (most front-end dev have their IDE already working with prettier)
Solution:
This introduce an opinionated formatter to have better consistency in our front-end code base.
eslintconfigstylelintconfig