Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat chart templates part 3 #30312

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Mar 26, 2023

The PR reformats multiple chart templates as the continuation of #29917 and #29941
Less empty lines rendered when helm template is executed. Aligned indent style for templates.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Mar 26, 2023
@dnskr dnskr force-pushed the reformat_chart_templates_part_3 branch from 6596bf4 to defa618 Compare March 26, 2023 17:05
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Pending passing the tests.

@dnskr
Copy link
Contributor Author

dnskr commented Apr 5, 2023

Helm Unit Tests were cancelled after 80 minutes and 98% of progress.
Is it possible to rerun it?

@potiuk
Copy link
Member

potiuk commented Apr 5, 2023

I will re-run it but this likely means that there is some problem with your change. This is the second time it happens for the PR in a row:

Usually the tests on public runner are a bit faster than 80 minutes (not by long margin, so this might be small difference causing it, but it is a bit disturbing if it is consistently longer than usual:

https://github.com/apache/airflow/actions/runs/4590214027/jobs/8142557270?pr=30168

Let's see. Maybe it's time to seriously look at speeding those tests up. They take a long time to run.

@dnskr
Copy link
Contributor Author

dnskr commented Apr 5, 2023

Helm unit tests are Successful in 69m this time.

I'm not super excited about unit tests for the helm chart. I mean it's quite hard to run and maintain them, but I don't know and cannot find better/faster existing alternative.

@potiuk
Copy link
Member

potiuk commented Apr 5, 2023

so be it :)

@potiuk
Copy link
Member

potiuk commented Apr 18, 2023

I'm not super excited about unit tests for the helm chart. I mean it's quite hard to run and maintain them, but I don't know and cannot find better/faster existing alternative.

I have now merged #30672 - maybe not changing the unit tests, but at least grouping them in separate packages, (each one completing under 8 minutes). That should help quite a lot a least with re-running scenarios but also with running bigger chunks of related tests together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants