Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataprocCreateCluster operator to use 'label' parameter properly #30741

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

VladaZakharova
Copy link
Contributor

@VladaZakharova VladaZakharova commented Apr 19, 2023

Previously added 'label' parameter to ClusterGenerator class caused some misunderstanding for users: there is no ability to add labels by passing them as a parameter to cluster_config field as it is of type ClusterConfig, which has no such parameter. (please, check the documentation here: https://cloud.google.com/dataproc/docs/reference/rest/v1/ClusterConfig)

The label can be passed to the cluster by passing it as a parameter to DataprocCreateClusterOperator only:

DataprocCreateClusterOperator(
        task_id='create_dataproc_cluster',
        dag=dag,
        cluster_name='test-cluster',
        region='us-central1',
        labels={"a": "b"},
        cluster_config=ClusterGenerator(
            project_id=PROJECT_ID, labels=custom_labels).make()
    )

Updated a comment in the operator to mark this for users.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 19, 2023
@VladaZakharova VladaZakharova force-pushed the dataproc-cluster-generator branch from 42d7ec1 to 4a3aad1 Compare April 20, 2023 10:31
@VladaZakharova
Copy link
Contributor Author

@potiuk
Hi! Could you please approve these small changes? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants