restore fallback to empty connection behavior #30806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
|
I'm curious to hear what you think of this one @eladkal If you agree that it's worth merging, I'd like to vote we include this as an RC2 for this amazon provider release. We rushed in these deprecation changes a bit, and didn't test them as much as we should have. |
|
If AWS believes that this part of the code was not suppose to be deprecated to begin with than lets restore it. |
40 tasks
eladkal
approved these changes
Apr 21, 2023
o-nikolas
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was removed as part of a big PR (#30755) to get rid of all old code that was marked obsolete, but this specific thing is pretty tricky to fix if it breaks customer code.
Also, doing this fallback does not prevent us from moving forward with other things, so I think we should better keep it around, and even not treat it as a deprecated behavior.