Append region info to S3ToRedshitOperator if present #32328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to copy from S3 into Redshift across different regions, however, currently you are unable to do so with the S3ToRedshiftOperator. This PR simply makes this possible, by checking the aws connection passed has the region set in the extras part of the connection config. If this is set, it'll use this in line with the syntax defined [here](https://docs.aws.amazon.com/redshift/latest/dg/r_COPY.html)
boring-cyborg
bot
added
area:providers
provider:amazon
Adaverse
reviewed
Jul 3, 2023
Following on from discussion in PR, currently the way assertion is done is kind of redundant, as it's asserting static variables == other static variables. Instead, this now gets compared to what gets generated from the `_build_copy_query` function, this has been reflected for all applicable test cases in this file.
|
I've removed the comments you highlighted @Adaverse , hope things look okay now |
|
some static checks. I recommend to install pre-commit and use it locally |
Adaverse
approved these changes
Jul 5, 2023
|
You can look at instructions here to run static checks |
|
All checks are passing now |
potiuk
reviewed
Jul 11, 2023
| column_names = "(" + ", ".join(self.column_list) + ")" if self.column_list else "" | ||
| return f""" | ||
| COPY {copy_destination} {column_names} | ||
| FROM 's3://{self.s3_bucket}/{self.s3_key}' | ||
| credentials | ||
| '{credentials_block}' | ||
| {region_info} |
There was a problem hiding this comment.
Will that work when region is None? I srsly doubt
There was a problem hiding this comment.
Nice catch. It can only be None when user passes null in the extra config. Should be handled explicitly.
There was a problem hiding this comment.
Good spot, I've updated the parameter to not default to None which prevents the possibility of this happening
potiuk
approved these changes
Jul 11, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to copy from S3 into Redshift across different regions, however, currently you are unable to do so with the S3ToRedshiftOperator. This PR simply makes this possible, by checking the aws connection passed has the region set in the extras part of the connection config. If this is set, it'll use this in line with the syntax defined here
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.