-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix headers passed into HttpAsyncHook #32409
Merged
potiuk
merged 5 commits into
apache:main
from
sumeshpremraj:spremraj/fix-HttpAsyncHook-headers
Jul 6, 2023
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c4a4bf2
fix headers passed into HttpAsyncHook
sumeshpremraj 095f0cf
Merge branch 'main' into spremraj/fix-HttpAsyncHook-headers
sumeshpremraj d873c4c
Fix unit test for Python 3.7
sumeshpremraj 1ab58d1
Revert "Fix unit test for Python 3.7"
sumeshpremraj 3d06d6d
Merge branch 'main' into spremraj/fix-HttpAsyncHook-headers
sumeshpremraj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont support Python 3.7 any longer.
If you check the test suite you will see it tests against 3.8 - 3.11
Where did you notice failure related to Python 3.7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the stale PR https://github.com/apache/airflow/actions/runs/4885483415/jobs/8719703717?pr=31010
I understand Py 3.7 support will be dropped only in the next Airflow release, but I didn't realize the test suites have already dropped it, sorry about that.
I've reverted the Py 3.7 related changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is provider code :)
You can see in the change log that we already dropped support
https://airflow.apache.org/docs/apache-airflow-providers-github/stable/index.html#id1
Python 3.7 is relevant only for Airflow 2.6 releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah TIL, this is my first time contributing to Airflow, I've only been a user until now.
Thanks for the review 😄