Rename "bucket" to "gcs_bucket" in GCSToS3Operator #33031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
hankehly
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
hankehly
commented
Sep 17, 2023
| @@ -117,7 +120,21 @@ def __init__( | |||
| ) -> None: | |||
| super().__init__(**kwargs) | |||
|
|
|||
| self.bucket = bucket | |||
| if bucket and gcs_bucket: | |||
There was a problem hiding this comment.
bucket is still accepted, but outputs a deprecation warning.
hankehly
commented
Sep 17, 2023
|
@ferruzzi This is the PR we briefly talked about in this other issue. I would appreciate your review. |
eladkal
removed
the
stale
eladkal
reviewed
Sep 17, 2023
vincbeck
reviewed
Sep 18, 2023
| @@ -117,7 +119,23 @@ def __init__( | |||
| ) -> None: | |||
| super().__init__(**kwargs) | |||
|
|
|||
| self.bucket = bucket | |||
| if bucket and gcs_bucket: | |||
There was a problem hiding this comment.
Do we need this check? If both are provided, we should use gcs_bucket IMO. To me we should do (pseudo code):
if bucket:
warnings.warn()
self.gcs_bucket = bucket
if gcs_bucket:
self.gcs_bucket = gcs_bucketAs such, if both are provided, gcs_bucket is used
| raise ValueError("You must pass either bucket or gcs_bucket.") | ||
| # The bucket attribute is unused, but must be set on the operator instance in | ||
| # order to include it in template_fields. | ||
| self.bucket = None |
vincbeck
reviewed
Sep 25, 2023
Feedback updates Co-authored-by: Vincent <[email protected]>
vincbeck
approved these changes
Sep 26, 2023
98 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #32760
This pull request renames
buckettogcs_bucketon theGCSToS3Operatorclass to distinguish between AWS and GCP buckets. The change supports both parameter names but issues a deprecation warning forbucket.Here are the corresponding unit/system tests:
Your review is appreciated.