Implement AthenaSQLHook #36171
Merged
Implement AthenaSQLHook #36171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
reviewed
Dec 11, 2023
flolas
force-pushed
the
feat/athena_sql_hook
branch
from
a8baa4d to
2de24b6
Compare
Taragolis
reviewed
Dec 12, 2023
josh-fell
reviewed
Dec 13, 2023
eladkal
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Please add docs for using the operator.
We probably will need also index added to explain the difference between the two options and then point to the specific doc of the relevant option.
You can see example of how we do it for Redshift
https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/operators/redshift/index.html
Should be easy to be done. If you need help with it let me know
flolas
force-pushed
the
feat/athena_sql_hook
branch
3 times, most recently
from
70207e8 to
a9f651f
Compare
vincbeck
approved these changes
Dec 14, 2023
flolas
force-pushed
the
feat/athena_sql_hook
branch
from
a9f651f to
93dae69
Compare
eladkal
reviewed
Dec 15, 2023
flolas
commented
Dec 15, 2023
flolas
force-pushed
the
feat/athena_sql_hook
branch
from
071fa23 to
37e80f9
Compare
eladkal
approved these changes
Dec 16, 2023
flolas
force-pushed
the
feat/athena_sql_hook
branch
2 times, most recently
from
a32133a to
5736fd2
Compare
|
@eladkal could you help me with the spellcheck test? can't find what's wrong. thx! |
|
|
Interesting, I have a very similar error message in one of my open PRs and cannot figure out why. I am very interested if someone knows the reason |
|
It seems, Sphinx has some issues referencing a document not built yet. See https://apache-airflow.slack.com/archives/CJ1LVREHX/p1702929226260749. In other words, here you are creating a new file (renaming a file is like creating a new file for Sphinx) and are referring this file. It seems Sphinx does not like it. One way to solve it would be to keep the old file for now and delete it in another PR |
flolas
force-pushed
the
feat/athena_sql_hook
branch
from
5736fd2 to
e87f135
Compare
flolas
force-pushed
the
feat/athena_sql_hook
branch
from
e443580 to
e5dcfd1
Compare
|
Will this work with AWS credentials provider chain? I'm thinking about mwaa environments where the aws_default conn_id is used for most aws hooks. |
Taragolis
reviewed
Dec 19, 2023
|
@flolas what is the status of this PR? I'm hoping to get it to the next provider release. |
flolas
force-pushed
the
feat/athena_sql_hook
branch
2 times, most recently
from
2aed8f6 to
25fffe0
Compare
|
@eladkal Ummh, I can't figure out why spellcheck test fails with errors like this: After resolving this issue (if you could give me a hand, that would be great), I need to fix some hook tests due to some changes I made in response to @Taragolis' comments/suggestions (but that's the easy part). |
|
I can see: Adding |
Yeah sounds good, but why is this showing up in my PR when I'm only changing the Amazon provider and nothing else? Is this a expected behaviour of the spellcheck test? |
flolas
force-pushed
the
feat/athena_sql_hook
branch
2 times, most recently
from
a43268e to
fadd899
Compare
Co-authored-by: Vincent <[email protected]> Co-authored-by: Josh Fell <[email protected]> Co-authored-by: Andrey Anshin <[email protected]>
flolas
force-pushed
the
feat/athena_sql_hook
branch
from
fadd899 to
28cc91f
Compare
|
@eladkal Tests seems good now 👍 , can you review again the code? I made some changes to address @Taragolis comments. thanks! |
eladkal
approved these changes
Jan 17, 2024
|
🎉 🎉🎉 |
potiuk
pushed a commit
that referenced
this pull request
Feb 7, 2024
Co-authored-by: Vincent <[email protected]> Co-authored-by: Josh Fell <[email protected]> Co-authored-by: Andrey Anshin <[email protected]> (cherry picked from commit 6661272)
potiuk
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
Co-authored-by: Vincent <[email protected]> Co-authored-by: Josh Fell <[email protected]> Co-authored-by: Andrey Anshin <[email protected]> (cherry picked from commit 6661272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this Pull Request, we're introducing the
AthenaSQLHook, an implementation leveraging PyAthena. This development opens doors for us to interact with Athena using the familiar DBApiHook operators.Close: #34823
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.