Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Google Analytics Admin (GA4) operators #36276

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

moiseenkov
Copy link
Contributor

Due to upcoming Google Analytics Management API v3 sunset Google Analytics 360 Operators are deprecated and new operators are introduced in this PR:

  • GoogleAnalyticsAdminCreateDataStreamOperator
  • GoogleAnalyticsAdminCreatePropertyOperator
  • GoogleAnalyticsAdminDeleteDataStreamOperator
  • GoogleAnalyticsAdminDeletePropertyOperator
  • GoogleAnalyticsAdminGetGoogleAdsLinkOperator
  • GoogleAnalyticsAdminListAccountsOperator
  • GoogleAnalyticsAdminListGoogleAdsLinksOperator
  • GoogleAnalyticsAdminGetGoogleAdsLinkOperator

@moiseenkov moiseenkov force-pushed the google_analytics_admin_operators branch 26 times, most recently from dfef6c1 to efce016 Compare December 22, 2023 08:17
@moiseenkov moiseenkov force-pushed the google_analytics_admin_operators branch 4 times, most recently from b8e5a51 to 5e6ed43 Compare December 28, 2023 11:27
@VladaZakharova
Copy link
Contributor

Hi @potiuk !
Could you please take a look on these changes? We can't understand why there is this problem with spelling :D
As a master of Sphinx, maybe you can share your ideas on this?
Thank you very much!

@moiseenkov moiseenkov force-pushed the google_analytics_admin_operators branch 2 times, most recently from 72c55e8 to 1f0e4a1 Compare December 29, 2023 16:58
@potiuk
Copy link
Member

potiuk commented Dec 29, 2023

@VladaZakharova The solution will be (likely) to increase the timeout for spellcheck job. The problem is that in this case there are some cross-changes between packages, that makes it necessary for spellcheck job to perform a second pass of spell-check build - this time including building all the packages from scratch - and altogether, when public runners are used it makes the job run for > 60 minutes. Currenty in ci.yml you have:

  spellcheck-docs:
    timeout-minutes: 60

And it causes the CI job to be cancelled after ~ 60 minutes (as you could guess).

Increasing that to 120 minutes should help.

@moiseenkov moiseenkov force-pushed the google_analytics_admin_operators branch 2 times, most recently from 6b58317 to 264c562 Compare January 2, 2024 10:24
@moiseenkov moiseenkov force-pushed the google_analytics_admin_operators branch from 264c562 to 86ad82a Compare January 2, 2024 10:46
@moiseenkov
Copy link
Contributor Author

Hi Jarek,
Thank you for your advice - it helped to pass the spell check. So this PR is ready for review now.
@potiuk

@moiseenkov moiseenkov force-pushed the google_analytics_admin_operators branch 2 times, most recently from 94462d1 to 74f0d62 Compare January 3, 2024 11:25
@moiseenkov moiseenkov closed this Jan 3, 2024
@moiseenkov moiseenkov reopened this Jan 3, 2024
@moiseenkov moiseenkov force-pushed the google_analytics_admin_operators branch from 74f0d62 to 44194a1 Compare January 3, 2024 13:25
@moiseenkov moiseenkov force-pushed the google_analytics_admin_operators branch from 44194a1 to 2308ef2 Compare January 3, 2024 13:31
@potiuk potiuk merged commit f28643b into apache:main Jan 3, 2024
74 checks passed
potiuk pushed a commit that referenced this pull request Jan 13, 2024
@potiuk potiuk added this to the Airflow 2.8.1 milestone Jan 13, 2024
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2024
ephraimbuddy pushed a commit that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:system-tests changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants