-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to automatically ingest custom airflow.cfg file upon startup #36289
Added functionality to automatically ingest custom airflow.cfg file upon startup #36289
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
…pon startup and the associated documentation
e4743c6
to
05bfc1a
Compare
… env. var and adjusted documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Redundant whitespaces / newlines
- Missing whitespaces in the beginning of the comment (needs for pass statics checks)
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
closes: #35812
I have made the necessary changes to the docker-compose.yaml file as proposed within the issue. The relevant line is currently outcommented, but the documentation in the index.rst and comments above the outcommented line tell users
what to do. If one deletes the comment, an airflow.cfg file within
${AIRFLOW_PROJ_DIR:-.}
is now added to/opt/airflow/airflow.cfg
within the containers, oncedocker compose up
has been executed. The new line also should make it clear where the airflow.cfg is stored in the containers, as brought up by the issue.As mentioned, I also added documentation for the changes in the index.rst file, such that users know how to automatically ingest their own airflow.cfg upon startup.
@potiuk Can you maybe have a look at this, since you also approved the original issue?
If I should change anything please let me know :)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.