add type annotations to Amazon provider "execute_coplete" methods #36330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Lee-W
force-pushed
the
amazon-provider-improvement
branch
from
b1c5950 to
4d533b7
Compare
syedahsn
reviewed
Jan 16, 2024
|
I'll probably defer this one a bit. I'm thinking of extracting the event check method to the base hook so that we don't need to rewrite it everywhere. |
Lee-W
force-pushed
the
amazon-provider-improvement
branch
from
4d533b7 to
0df2772
Compare
Lee-W
changed the title
…lidate_execute_complete_event
Lee-W
force-pushed
the
amazon-provider-improvement
branch
from
4c17b76 to
3198d09
Compare
Lee-W
force-pushed
the
amazon-provider-improvement
branch
from
3198d09 to
538b30c
Compare
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.