-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit atlassian-python-api
to <3.41.6
#36815
Limit atlassian-python-api
to <3.41.6
#36815
Conversation
3427da6
to
fe1791a
Compare
atlassian-python-api
to <3.41.5atlassian-python-api
to <3.41.6
Suggestion: should we use != instead of < ? This seems like a "popular" issue and the way it is implemented it's quite likely they will fix it in the next patchlevel, if we use != we would not have to make another PR changing < into !=. |
+1. We did this with |
Ah, I see they attempted to fix it and failed in .6, so maybe we should != both versions and assume they learned from .6 and .7 will be fixing it "properly" - if we keep our faith in Atlassian learning from mistakes that is :) |
BTW. They got that rather reasonable comment atlassian-api/atlassian-python-api#1295 (comment) about their CI not doing the right things - which I sympathise with a lot. While our CI misses things sometimes - this is precisely what we do if we see things like that, we add a test that basicaly tests what we failed to catch before. |
Yeah I also think that |
Remaining red checks not related to this PR Non-DB test: new major version of < pinecone-client==2.2.4
---
> pinecone-client==3.0.0
|
yeah. Let's merge it - seems like we have flurry of breaking dependencies (and our mistakes). |
(cherry picked from commit 4d59fbc)
(cherry picked from commit 4d59fbc)
atlassian-python-api
3.41.5 introduce a bug with beautifulsoup (missing dependency) it not failed in our CI because one because we pre-install it for some other package, hotfix version3.41.6
introduce another bug with import unknown package.For avoid any issues better to upper bound dependency until it properly fixed
In addition add
beautifulsoup
as dependency for a providerUpstream issue/PRs:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.