Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator to collect diagnostic tarball for Dataproc cluster #36899

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

flacode
Copy link
Contributor

@flacode flacode commented Jan 19, 2024

  1. Make diagnose_cluster hook return Operation object just like the rest of the hooks.
  2. Rename DataprocWorkflowTrigger to DataprocOperationTrigger handle all types of operations for get_operation.
  3. Add new operator to capture diagnostic tarball for Dataproc clusters.

closes: #36173


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jan 19, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@flacode flacode force-pushed the diagnose-cluster-operator branch from 044d213 to c65f934 Compare January 19, 2024 12:23
@flacode flacode marked this pull request as draft January 22, 2024 19:27
@flacode flacode force-pushed the diagnose-cluster-operator branch 2 times, most recently from 7bb22e1 to 28d1f9a Compare January 22, 2024 19:49
@flacode flacode marked this pull request as ready for review January 22, 2024 19:54
@flacode flacode force-pushed the diagnose-cluster-operator branch from 28d1f9a to 2dc26cf Compare January 22, 2024 21:48
@flacode flacode force-pushed the diagnose-cluster-operator branch 2 times, most recently from 98a2eb3 to 528fa9e Compare January 23, 2024 19:24
1. Make diagnose_cluster hook return Operation object just like the rest of the hooks.
2. Rename DataprocWorkflowTrigger to DataprocOperationTrigger handle all types of
operations for get_operation
@flacode flacode force-pushed the diagnose-cluster-operator branch from 528fa9e to f914b73 Compare January 24, 2024 10:21
@potiuk potiuk merged commit 10ad8d9 into apache:main Jan 25, 2024
55 checks passed
Copy link

boring-cyborg bot commented Jan 25, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:system-tests changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add operator to capture diagnostic tarball for Dataproc
3 participants