Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLThresholdCheckOperator error on falsey vals #37150

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

Don-Burns
Copy link
Contributor

@Don-Burns Don-Burns commented Feb 2, 2024


Summary

As documented in #37089 the SQLThresholdCheckOperator will currently fail if a "falsey" value is returned from the query (e.g. 0 or "").
This is a fix to change the error check a bit and as side effect make the exception for The following query returned zero rows:...
Whereas before, if no rows really were returned, the user would see the following:

result = hook.get_first(self.sql)[0]
TypeError: 'NoneType' object is not subscriptable

For testing, I used a parameterized test on an existing test and added a new test to cover the "no rows returned" case.
But please let me know if something else would be preferable.

closes: #37089

Copy link

boring-cyborg bot commented Feb 2, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

If the user's query returned a "falsey" value e.g. 0 an exception would be falsely raised
@potiuk potiuk merged commit b6ca847 into apache:main Feb 15, 2024
58 checks passed
Copy link

boring-cyborg bot commented Feb 15, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

common-sql SQLThresholdCheckOperator always returns error if query yields value of 0
3 participants