Fix SQLThresholdCheckOperator error on falsey vals #37150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As documented in #37089 the SQLThresholdCheckOperator will currently fail if a "falsey" value is returned from the query (e.g. 0 or "").
This is a fix to change the error check a bit and as side effect make the exception for
The following query returned zero rows:...
Whereas before, if no rows really were returned, the user would see the following:
For testing, I used a parameterized test on an existing test and added a new test to cover the "no rows returned" case.
But please let me know if something else would be preferable.
closes: #37089