Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Datapipeline operators and fix system tests #39716

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

VladaZakharova
Copy link
Contributor

This PR:

Removes datapipeline module from Google provider
Moves all the related operators inside Dataflow service, based on the API that is used inside operators
Adds new DataflowCreatePipeline, DataflowRunPipelineOperator and DataflowDeletePipelineOperator
Adds new system test file for new operators


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)
See my comment in Elad's thread and another one regarding naming convention

@VladaZakharova VladaZakharova force-pushed the datapipeline-sys-test branch from 8cfb3c8 to 8e5da8f Compare June 5, 2024 09:58
@VladaZakharova VladaZakharova requested a review from shahar1 June 5, 2024 10:06
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@VladaZakharova
Copy link
Contributor Author

Hi @eladkal ! Can you please check changes again here? :)

@potiuk potiuk force-pushed the datapipeline-sys-test branch from 8e5da8f to 7aafd3f Compare June 14, 2024 15:24
@potiuk
Copy link
Member

potiuk commented Jun 14, 2024

Rebased to see if still green

@potiuk potiuk merged commit 3e88f47 into apache:main Jun 14, 2024
51 checks passed
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 1, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:system-tests changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants