-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opensearch operator set connection type #39788
Merged
eladkal
merged 12 commits into
apache:main
from
infrabel:feature/opensearch-operator-connection
Jun 8, 2024
Merged
Opensearch operator set connection type #39788
eladkal
merged 12 commits into
apache:main
from
infrabel:feature/opensearch-operator-connection
Jun 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
reviewed
May 24, 2024
{
"use_ssl": true,
"verify_certs": false
} |
cjames23
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Taragolis
reviewed
May 31, 2024
eladkal
approved these changes
Jun 8, 2024
96 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…rtificate (apache#39788) * feat: added connection options * feat: opensearch hook unit tests * feat: fallback to RequestsHttpConnection * fix: static checks * fix: static checks * fix: static checks * feat: opensearch static module loading --------- Co-authored-by: Lukas Verret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into issues when trying the Opensearch operator to connect to an endpoint with a self-signed certificate. It even failed with the following connection settings:
Those parameters were converted to strings and not as booleans.
Another issue we faced is that the connection type RequestsHttpConnection did not work for us. We discovered it because we knew the Opensearch client itself worked which uses by default a Urllib3HttpConnection, but the hook does not.
This PR addresses both issues:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.